Closed
Bug 1333557
Opened 9 years ago
Closed 9 years ago
Fix packaging failure when purple is not enabled
Categories
(Instantbird Graveyard :: Other, defect)
Instantbird Graveyard
Other
Tracking
(Not tracked)
RESOLVED
FIXED
Instantbird 54
People
(Reporter: aleth, Assigned: aleth)
Details
Attachments
(1 file)
|
1.30 KB,
patch
|
clokep
:
review+
|
Details | Diff | Splinter Review |
This would break current nightlies if they weren't broken anyway.
The cause is that the code that sets MOZ_PURPLE checks for the existence of the purple directory instead of for the mozconfig flag.
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8830021 -
Flags: review?(clokep)
|
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → aleth
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•9 years ago
|
||
This works as --enable-extensions=purple adds 'purple' to MOZ_EXTENSIONS, which we check for here. The code that handles --enable-extensions already checks for the existence of a purple dir, so we don't need to repeat that in the im configure.
|
||
Updated•9 years ago
|
Attachment #8830021 -
Flags: review?(clokep) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
And it fixes packaging because that already checks for MOZ_PURPLE.
|
|
Assignee | |
Comment 4•9 years ago
|
||
https://hg.mozilla.org/comm-central/rev/ebbcdc168ef5de1b525b924815057e3207bc552e
Bug 1333557 - Use the extensions mechanism to set MOZ_PURPLE. r=clokep
|
|
Assignee | |
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Instantbird 54
You need to log in
before you can comment on or make changes to this bug.
Description
•