Closed Bug 1333620 Opened 3 years ago Closed 3 years ago

Doorhanger message to restart the browser is missing when Permissions is enabled

Categories

(Toolkit :: Add-ons Manager, defect, P1)

defect

Tracking

()

VERIFIED FIXED
mozilla54
Tracking Status
firefox51 --- unaffected
firefox52 --- unaffected
firefox53 --- affected
firefox54 --- verified

People

(Reporter: krupa--use, Assigned: aswan)

References

()

Details

(Whiteboard: triaged)

Attachments

(1 file)

application.version 54.0a1 
application.channel nightly
buildId	20170124030205

steps to reproduce:
1. Start a fresh profile
2. Set xpinstall.signatures.required to false.
3. Load https://addons-dev.allizom.org/en-US/firefox/addon/video-downloadhelper/versions/
4. Install the version - Version 4.9.17.1-signed and notice the doorhangers. There is a doorhanger prompting the user to restart the add-on after successful install
5. Go to about:config
6. Create extensions.webextPermissionPrompts and set it to true
7. Repeat step #4

expected behavior:
After installation, the doorhanger prompts the user to restart the browser whenever appropriate.

actual behavior:
There is no restart prompt after installation if permissions are enabled. User needs to navigate to the Add-ons manager to be informed that they need to restart the browser.

screencast:
screencast without permissions: https://screencast.com/t/MTBE2Pfju
screencast with permissions: https://screencast.com/t/6tn0rCVW
Markus, what is the expectation for post-install notifications for non-webextensions?  Do we show the old confirmation notification?  Or do we show the new notification and add the restart message (and now/later buttons) from the old notification to the new one when needed?
Flags: needinfo?(mjaritz)
Hi Andrew,
if an extension needs a restart, we should keep showing the restart-notification as we do now.
After the restart we can then show the confirmation message. (probably difficult if the users clicks "not now" as we then can not guarantee that the tab is still open.)
Flags: needinfo?(mjaritz)
Okay, I can switch it to show the old dialog in this case.
Showing the confirmation after the restart is a bunch of work, given that add-ons that require a restart are going away relatively soon, I'm inclined to just skip it in that case.
I agree. We shouldn't put a lot of work in something that will be gone in a few versions.
Whiteboard: triaged
Priority: -- → P1
Component: WebExtensions: General → Add-ons Manager
Attachment #8833088 - Flags: review?(rhelmer)
Attachment #8833088 - Flags: review?(rhelmer) → review?(dtownsend)
Comment on attachment 8833088 [details]
Bug 1333620 Show the old post-install confirmation for non-restartless extensions

https://reviewboard.mozilla.org/r/109310/#review110428
Attachment #8833088 - Flags: review?(dtownsend) → review+
Pushed by aswan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9b4b7718e37d
Show the old post-install confirmation for non-restartless extensions r=mossop
https://hg.mozilla.org/mozilla-central/rev/9b4b7718e37d
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Confirm that “Restart” pop-up is successfully displayed while installing add-ons which require restart on Firefox 54.0a1 (2017-02-15/16) under Windows 10 64-bit, Ubuntu 16.04 32-bit and Mac OS X 10.12.1 ( https://www.screencast.com/t/LhEfvYfuxC )

This issues is still reproducible on Firefox 53.0a2 (2017-02-16). Setting the tracking flags accordingly.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.