1333660 - Assertion failure: mHasActivePage (We can't guarantee a valid DrawTarget)

Status: RESOLVED FIXED

(Core :: Printing: Output, defect)

Comment 1

[Farmer Tseng[:fatseng](inactive)]

While printing in Windows with debug build, I hit this assertion.

Assertion failure: mHasActivePage (We can't guarantee a valid DrawTarget), at c:/mozilla-source/gecko-0124/gfx/thebes/PrintTarget.cpp:68
#01: nsDeviceContext::CreateRenderingContextCommon (c:\mozilla-source\gecko-0124\gfx\src\nsdevicecontext.cpp:354)
#02: nsDeviceContext::CreateRenderingContext (c:\mozilla-source\gecko-0124\gfx\src\nsdevicecontext.cpp:331)
#03: mozilla::layout::PrintTranslator::CreateDrawTarget (c:\mozilla-source\gecko-0124\layout\printing\printtranslator.cpp:75)
#04: mozilla::gfx::RecordedDrawTargetCreation::PlayEvent (c:\mozilla-source\gecko-0124\gfx\2d\recordedevent.cpp:398)
#05: mozilla::layout::PrintTranslator::TranslateRecording (c:\mozilla-source\gecko-0124\layout\printing\printtranslator.cpp:60)
#06: mozilla::layout::RemotePrintJobParent::PrintPage (c:\mozilla-source\gecko-0124\layout\printing\ipc\remoteprintjobparent.cpp:128)
#07: mozilla::layout::RemotePrintJobParent::RecvProcessPage (c:\mozilla-source\gecko-0124\layout\printing\ipc\remoteprintjobparent.cpp:88)
#08: mozilla::layout::PRemotePrintJobParent::OnMessageReceived (c:\mozilla-source\gecko-0124\obj-i686-pc-mingw32\ipc\ipdl\premoteprintjobparent.cpp:250)
#09: mozilla::dom::PContentParent::OnMessageReceived (c:\mozilla-source\gecko-0124\obj-i686-pc-mingw32\ipc\ipdl\pcontentparent.cpp:2856)
#10: mozilla::ipc::MessageChannel::DispatchAsyncMessage (c:\mozilla-source\gecko-0124\ipc\glue\messagechannel.cpp:1773)
#11: mozilla::ipc::MessageChannel::DispatchMessageW (c:\mozilla-source\gecko-0124\ipc\glue\messagechannel.cpp:1710)
#12: mozilla::ipc::MessageChannel::RunMessage (c:\mozilla-source\gecko-0124\ipc\glue\messagechannel.cpp:1590)
#13: mozilla::ipc::MessageChannel::MessageTask::Run (c:\mozilla-source\gecko-0124\ipc\glue\messagechannel.cpp:1615)
#14: nsThread::ProcessNextEvent (c:\mozilla-source\gecko-0124\xpcom\threads\nsthread.cpp:1240)
#15: NS_ProcessNextEvent (c:\mozilla-source\gecko-0124\xpcom\glue\nsthreadutils.cpp:390)
#16: mozilla::ipc::MessagePump::Run (c:\mozilla-source\gecko-0124\ipc\glue\messagepump.cpp:96)
#17: MessageLoop::RunInternal (c:\mozilla-source\gecko-0124\ipc\chromium\src\base\message_loop.cc:239)
#18: MessageLoop::RunHandler (c:\mozilla-source\gecko-0124\ipc\chromium\src\base\message_loop.cc:232)
#19: MessageLoop::Run (c:\mozilla-source\gecko-0124\ipc\chromium\src\base\message_loop.cc:212)
#20: nsBaseAppShell::Run (c:\mozilla-source\gecko-0124\widget\nsbaseappshell.cpp:158)
#21: nsAppShell::Run (c:\mozilla-source\gecko-0124\widget\windows\nsappshell.cpp:262)
#22: nsAppStartup::Run (c:\mozilla-source\gecko-0124\toolkit\components\startup\nsappstartup.cpp:283)
#23: XREMain::XRE_mainRun (c:\mozilla-source\gecko-0124\toolkit\xre\nsapprunner.cpp:4461)
#24: XREMain::XRE_main (c:\mozilla-source\gecko-0124\toolkit\xre\nsapprunner.cpp:4638)
#25: XRE_main (c:\mozilla-source\gecko-0124\toolkit\xre\nsapprunner.cpp:4729)
#26: mozilla::BootstrapImpl::XRE_main (c:\mozilla-source\gecko-0124\toolkit\xre\bootstrap.cpp:45)
#27: do_main (c:\mozilla-source\gecko-0124\browser\app\nsbrowserapp.cpp:235)
#28: NS_internal_main (c:\mozilla-source\gecko-0124\browser\app\nsbrowserapp.cpp:305)
#29: wmain (c:\mozilla-source\gecko-0124\toolkit\xre\nswindowswmain.cpp:115)
#30: __scrt_common_main_seh (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:253)
#31: BaseThreadInitThunk[C:\Windows\syswow64\kernel32.dll +0x1336a]
#32: RtlInitializeExceptionChain[C:\Windows\SysWOW64\ntdll.dll +0x39902]
#33: RtlInitializeExceptionChain[C:\Windows\SysWOW64\ntdll.dll +0x398d5]

Comment 2

[Farmer Tseng[:fatseng](inactive)]

Attachment: Bug 1333660 - Assertion failure: mHasActivePage (We can't guarantee a valid DrawTarget)

Review commit: https://reviewboard.mozilla.org/r/107076/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/107076/

Comment 3

[Farmer Tseng[:fatseng](inactive)]

Comment on attachment 8830184 [details]
Bug 1333660 - Assertion failure: mHasActivePage (We can't guarantee a valid DrawTarget)

Call PrintTarget::BeginPage() and PrintTarget::EndPage() in PrintTargetWindows to set mHasActivePage as propriate.

Comment 4

[Jonathan Watt [:jwatt]]

Comment on attachment 8830184 [details]
Bug 1333660 - Assertion failure: mHasActivePage (We can't guarantee a valid DrawTarget)

https://reviewboard.mozilla.org/r/107076/#review108186

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3e459ccf6e09
Assertion failure: mHasActivePage (We can't guarantee a valid DrawTarget) r=jwatt

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3e459ccf6e09