1333684 - Add tests that the GPU process is running

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[David Anderson [:dvander] - inactive, e-mail if emergency]

We want to ensure that we're actually running the GPU process on Windows 8/10 reftests, and on the Windows 7 reftest-unaccelerated-gpuproc job. I think we can hack something into place by having reftests that always fail, but only running them if the system configuration doesn't match the gpu process state.

Comment 1

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: bug1333684.patch

Comment 2

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8830167 [details] [diff] [review]
bug1333684.patch

Review of attachment 8830167 [details] [diff] [review]:
-----------------------------------------------------------------

Rather than adding new files you could just inline the failing test (like reftest-sanity does).

Something like: == data:text/plain,HELLO about:blank

Comment 3

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: v2

This failed anyway, calling getBoolPref throws an error if the pref doesn't exist. Wrapping it in a try block led to some sadness, so here's a new version.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8830587 [details] [diff] [review]
v2

Review of attachment 8830587 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/tools/reftest/reftest.jsm
@@ +747,3 @@
>      } catch (e) {
>          sandbox.nativeThemePref = true;
> +        sandbox.gpuProcessForceEnabled = false;

Don't you want to split this into two try conditions? Otherwise if the mozilla.widget pref isn't present the gpuProcessForceEnable gets locked to false.

Comment 5

[David Anderson [:dvander] - inactive, e-mail if emergency]

Good catch, thanks.

Comment 6

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: v3

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c7b22cdb4752
Add tests that the GPU process is running. (bug 1333684, r=mattwoodrow)

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c7b22cdb4752

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Thanks for doing this!

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/1f158e88b866