Closed Bug 1333684 Opened 4 years ago Closed 4 years ago

Add tests that the GPU process is running

Categories

(Core :: Graphics: Layers, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox53 --- fixed
firefox54 --- fixed

People

(Reporter: dvander, Assigned: dvander)

Details

Attachments

(1 file, 2 obsolete files)

We want to ensure that we're actually running the GPU process on Windows 8/10 reftests, and on the Windows 7 reftest-unaccelerated-gpuproc job. I think we can hack something into place by having reftests that always fail, but only running them if the system configuration doesn't match the gpu process state.
Attached patch bug1333684.patch (obsolete) — Splinter Review
Attachment #8830167 - Flags: review?(matt.woodrow)
Comment on attachment 8830167 [details] [diff] [review]
bug1333684.patch

Review of attachment 8830167 [details] [diff] [review]:
-----------------------------------------------------------------

Rather than adding new files you could just inline the failing test (like reftest-sanity does).

Something like: == data:text/plain,HELLO about:blank
Attachment #8830167 - Flags: review?(matt.woodrow) → review+
Attached patch v2 (obsolete) — Splinter Review
This failed anyway, calling getBoolPref throws an error if the pref doesn't exist. Wrapping it in a try block led to some sadness, so here's a new version.
Attachment #8830167 - Attachment is obsolete: true
Attachment #8830587 - Flags: review?(matt.woodrow)
Comment on attachment 8830587 [details] [diff] [review]
v2

Review of attachment 8830587 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/tools/reftest/reftest.jsm
@@ +747,3 @@
>      } catch (e) {
>          sandbox.nativeThemePref = true;
> +        sandbox.gpuProcessForceEnabled = false;

Don't you want to split this into two try conditions? Otherwise if the mozilla.widget pref isn't present the gpuProcessForceEnable gets locked to false.
Good catch, thanks.
Attached patch v3Splinter Review
Attachment #8830587 - Attachment is obsolete: true
Attachment #8830587 - Flags: review?(matt.woodrow)
Attachment #8830607 - Flags: review?(matt.woodrow)
Attachment #8830607 - Flags: review?(matt.woodrow) → review+
Pushed by danderson@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c7b22cdb4752
Add tests that the GPU process is running. (bug 1333684, r=mattwoodrow)
https://hg.mozilla.org/mozilla-central/rev/c7b22cdb4752
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Thanks for doing this!
Whiteboard: [checkin-needed-aurora]
Whiteboard: [checkin-needed-aurora]
You need to log in before you can comment on or make changes to this bug.