1333721 - Convert utility functions in browser_contentSearchUI.js to be async

Status: RESOLVED FIXED

(Firefox :: Search, task, P5)

Description

[(inactive) Nihanth Subramanya [:nhnt11]]

Many utility functions in this test return either a promise and that is manually resolved or a Task.spawn(). They can easily be converted to ~generator~ async functions to make them much more readable and therefore less prone to timing issues.

Comment 1

[Mark Banner (:standard8)]

The functions where we have return (async () {...}()) we should change to simple async functions.

The msg function I think we need to leave as-is, as I don't see a simple way of making that not need to return a promise.

Looks like promiseMsg is unused.

Comment 2

[Ruchika Gosain]

Attachment: Bug 1333721 : Converted utility functions in browser_contentSearchUI.js to async r=standard8

Comment 3

[Ruchika Gosain]

Attachment: Bug 1333721 : Converted utility functions in browser_contentSearchUI.js to async r=standard8

Depends on D40237

Comment 4

[Ruchika Gosain]

Attachment: Bug 1333721 : Converted utility functions in browser_contentSearchUI.js to async r=standard8

Depends on D40238

Comment 5

[Ruchika Gosain]

Attachment: Bug 1333721 : Converted utility functions in browser_contentSearchUI.js to async r=standard8

Depends on D40239

Comment 6

[Ruchika Gosain]

Attachment: Bug 1333721 : Converted utility functions in browser_contentSearchUI.js to async r=standard8

Depends on D40241

Comment 7

[Ruchika Gosain]

Attachment: Bug 1333721 : Converted utility functions in browser_contentSearchUI.js to async r=standard8

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/28bc641c2e2b
Converted utility functions in browser_contentSearchUI.js to async r=Standard8

Comment 9

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/28bc641c2e2b