Closed Bug 1333721 Opened 3 years ago Closed 4 months ago

Convert utility functions in browser_contentSearchUI.js to be async

Categories

(Firefox :: Search, task, P5)

task

Tracking

()

RESOLVED FIXED
Firefox 70
Tracking Status
firefox54 --- wontfix
firefox70 --- fixed

People

(Reporter: nhnt11, Assigned: ruchikag826, Mentored)

Details

Attachments

(1 file, 5 obsolete files)

Many utility functions in this test return either a promise and that is manually resolved or a Task.spawn(). They can easily be converted to ~generator~ async functions to make them much more readable and therefore less prone to timing issues.
Status: ASSIGNED → NEW
Summary: Convert utility functions in browser_contentSearchUI.js to generators. → Convert utility functions in browser_contentSearchUI.js to be async
Assignee: nhnt11 → nobody
Type: defect → task
Priority: -- → P5

The functions where we have return (async () {...}()) we should change to simple async functions.

The msg function I think we need to leave as-is, as I don't see a simple way of making that not need to return a promise.

Looks like promiseMsg is unused.

Assignee: nobody → ruchikag826
Mentor: standard8
Attachment #9082311 - Attachment is obsolete: true
Attachment #9082317 - Attachment is obsolete: true
Attachment #9082316 - Attachment is obsolete: true
Attachment #9082314 - Attachment is obsolete: true
Attachment #9082313 - Attachment is obsolete: true
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/28bc641c2e2b
Converted utility functions in browser_contentSearchUI.js to async r=Standard8
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
You need to log in before you can comment on or make changes to this bug.