1333746 - Tooltip background color is dark, making text unreadable

Status: RESOLVED DUPLICATE of bug 1319353

(Core :: Widget: Gtk, defect)

Description

[Frédéric Buclin]

Attachment: screenshot.png

I updated Firefox on Linux from 50.1.0 to 51.0 last night, and now all tootips use a dark background color, making the text in the tooltips unreadable, see the screenshot.

Comment 1

[:Gijs (he/him)]

What GTK theme is this? Any chance you can find when exactly this broke? I suspect this is a GTK widget bug...

Comment 2

[Frédéric Buclin]

"gsettings get org.gnome.desktop.interface gtk-theme" returns 'Adwaita'.

No idea when it broke exactly. I updated from 50.1.0 to 51.0 directly. I didn't install any beta.

Comment 3

[:Gijs (he/him)]

(In reply to Frédéric Buclin from comment #2)
> "gsettings get org.gnome.desktop.interface gtk-theme" returns 'Adwaita'.
> 
> No idea when it broke exactly. I updated from 50.1.0 to 51.0 directly. I
> didn't install any beta.

OK, would you be able to run mozregression to figure it out? ( http://mozilla.github.io/mozregression/ )
From the commandline something like:

mozregression --good 50 --bad 51

should get you a pushlog on mozilla-central fairly quickly.

Comment 4

[Frédéric Buclin]

beta3 (20161124073320) is fine, beta4 (20161128075558) is not.

Comment 5

[Alice0775 White]

According to comment#4, regression window is
https://hg.mozilla.org/releases/mozilla-beta/pushloghtml?fromchange=f37e99ebc6e0c682003b52573f415e5fd78d425a&tochange=1b954c82dd04faf1926804d89c0d130dc6b9ab93

Suspect : bug 1315668

(btw, i cannot reproduce on ubuntu16.04)

Comment 6

[:Gijs (he/him)]

Thanks Alice. Looks like Karl is out. Martin, can you take a look as you reviewed the patch?

Comment 7

[Martin Stránský [:stransky] (ni? me)]

(In reply to :Gijs from comment #6)
> Thanks Alice. Looks like Karl is out. Martin, can you take a look as you
> reviewed the patch?

Sure. Which system/theme is that? Any Ubuntu or so? Thanks.

Comment 8

[:Gijs (he/him)]

[Tracking Requested - why for this release]: These fixes were uplifted and so they affect 51 and 52. We should ideally fix for 52.

(In reply to Martin Stránský from comment #7)
> (In reply to :Gijs from comment #6)
> > Thanks Alice. Looks like Karl is out. Martin, can you take a look as you
> > reviewed the patch?
> 
> Sure. Which system/theme is that? Any Ubuntu or so? Thanks.

Alice couldn't reproduce on Ubuntu (comment #5). Hopefully Frédéric can provide more specific info here (but it seems we can't needinfo them).

Comment 9

[Frédéric Buclin]

I'm using Mageia 5, KDE, theme Adwaita + Firefox 51.0.1 64-bit.

Comment 10

[Martin Stránský [:stransky] (ni? me)]

(In reply to Frédéric Buclin from comment #9)
> I'm using Mageia 5, KDE, theme Adwaita + Firefox 51.0.1 64-bit.

Thanks. Which gtk3 version there?

Comment 11

[Frédéric Buclin]

(In reply to Martin Stránský from comment #10)
> Thanks. Which gtk3 version there?

3.14.8

Comment 12

[Julien Cristau [:jcristau]]

Tracking for 52, might be nice to have this fixed for ESR.

Comment 13

[Martin Stránský [:stransky] (ni? me)]

Yes, I can reproduce that on KDE + Gtk 3.14.15 (Fedora 21). Seems to be KDE only.

Comment 14

[Martin Stránský [:stransky] (ni? me)]

The bug is already fixed in trunk (54/53). I'll use mozregression to find exact commit which fixes that.

Comment 15

[Martin Stránský [:stransky] (ni? me)]

This is a dupe of Bug 1319353 which fixes that.

Comment 17

[Liz Henry (:lizzard) (relman/hg->git project)]

Fixed in 52 in the duplicate.