Closed
Bug 1333757
Opened 8 years ago
Closed 8 years ago
Add same-compartment and not-marked-gray asserts to JSFunction's initExtendedSlot and setExtendedSlot and NativeObject's initFixedSlot and setFixedSlot
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla54
| Tracking | Status | |
|---|---|---|
| firefox54 | --- | fixed |
People
(Reporter: till, Assigned: till)
Details
Attachments
(1 file)
|
3.35 KB,
patch
|
jonco
:
review+
|
Details | Diff | Splinter Review |
We have similar asserts in NativeObject::setSlot, and really should have them for extended and fixed slots, too.
|
Assignee | |
Comment 1•8 years ago
|
||
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8830291 [details] [diff] [review]
Add asserts
Review of attachment 8830291 [details] [diff] [review]:
-----------------------------------------------------------------
Great, thanks for doing this.
Attachment #8830291 -
Flags: review?(jcoppeard) → review+
Pushed by tschneidereit@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b4448a970b05
Add some asserts to slot-setting functions on JSFunction and NativeObject. r=jonco
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•