Add same-compartment and not-marked-gray asserts to JSFunction's initExtendedSlot and setExtendedSlot and NativeObject's initFixedSlot and setFixedSlot

RESOLVED FIXED in Firefox 54

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: till, Assigned: till)

Tracking

Trunk
mozilla54
Points:
---

Firefox Tracking Flags

(firefox54 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
We have similar asserts in NativeObject::setSlot, and really should have them for extended and fixed slots, too.
(Assignee)

Comment 1

2 years ago
Created attachment 8830291 [details] [diff] [review]
Add asserts
Assignee: nobody → till
Status: NEW → ASSIGNED
Attachment #8830291 - Flags: review?(jcoppeard)
Comment on attachment 8830291 [details] [diff] [review]
Add asserts

Review of attachment 8830291 [details] [diff] [review]:
-----------------------------------------------------------------

Great, thanks for doing this.
Attachment #8830291 - Flags: review?(jcoppeard) → review+

Comment 3

2 years ago
Pushed by tschneidereit@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b4448a970b05
Add some asserts to slot-setting functions on JSFunction and NativeObject. r=jonco

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b4448a970b05
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox54: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.