1333767 - Add crypto params to PushRegistration

Status: RESOLVED FIXED

(Firefox for iOS :: Firefox Accounts, defect)

Description

[James Hugman [:jhugman] [@jhugman]]

This is pushAuthKey and pushPublicKey.

Comment 1

[James Hugman [:jhugman] [@jhugman]]

Helpful links culled from https://groups.google.com/a/mozilla.com/forum/#!topic/push-service/elV6tPy2sGU

HTTP ECE Draft Standard
https://datatracker.ietf.org/doc/draft-ietf-httpbis-encryption-encoding/

Gecko Implementation
http://searchfox.org/mozilla-central/source/dom/push/PushCrypto.jsm

Nodejs implementation of ECE.
https://github.com/martinthomson/encrypted-content-encoding/blob/master/nodejs/ece.js

Testing data: 
http://searchfox.org/mozilla-central/rev/b1aadb3572eaf7d2c70e19a2ba5413809d9ac698/dom/push/test/xpcshell/test_notification_data.js
http://searchfox.org/mozilla-central/rev/b1aadb3572eaf7d2c70e19a2ba5413809d9ac698/dom/push/test/xpcshell/test_crypto.js

Comment 2

[James Hugman [:jhugman] [@jhugman]]

Attachment: Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2568

Comment 3

[James Hugman [:jhugman] [@jhugman]]

This EVP example may prove useful. 

http://stackoverflow.com/a/13045182

Comment 4

[James Hugman [:jhugman] [@jhugman]]

:kit's C implementation will be useful https://github.com/kitcambridge/ecec

Comment 5

[James Hugman [:jhugman] [@jhugman]]

Attachment: Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2568

Comment 6

[Stephan Leroux [:sleroux]]

Comment on attachment 8851996 [details] [review]
Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2568

Looks good - Nice implementation.

Comment 7

[James Hugman [:jhugman] [@jhugman]]

Merged into master.