1333826 - Stop building/remove the Mozilla SDK support

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Benjamin Smedberg]

There is no point in building or shipping the Mozilla SDK any more, since it's point was to enable binary component compilation and that is no longer supported. This bug tracks the various bits of turning off building the SDK (and automation which ships it) as well as removing various bits of code that support it.

Comment 1

[Benjamin Smedberg]

Attachment: beetmoverscript PR

Comment 2

[Benjamin Smedberg]

Attachment: Bug 1333826 - Remove all references to MOZ_AUTOMATION_SDK,

Review commit: https://reviewboard.mozilla.org/r/107202/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/107202/

Comment 3

[Benjamin Smedberg]

Attachment: Bug 1333826 - Remove the make-sdk build target, the INSTALL_SDK variable, and all the supporting packager/upload machinery,

Review commit: https://reviewboard.mozilla.org/r/107204/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/107204/

Comment 4

[Benjamin Smedberg]

Attachment: Bug 1333826 - Remove SDK references from moz-automation.mk,

Review commit: https://reviewboard.mozilla.org/r/107206/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/107206/

Comment 5

[Benjamin Smedberg]

Attachment: Bug 1333826 - Remove SDK_FILES, SDK_LIBRARY, and related is_sdk support in the build goop,

Review commit: https://reviewboard.mozilla.org/r/107208/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/107208/

Comment 6

[Benjamin Smedberg]

Attachment: Bug 1333826 - Remove SDK references from taskcluster beetmover,

Review commit: https://reviewboard.mozilla.org/r/107210/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/107210/

Comment 7

[Benjamin Smedberg]

Attachment: Bug 1333826 - Remove a few references from .mk files,

Review commit: https://reviewboard.mozilla.org/r/107212/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/107212/

Comment 8

[Jordan Lund (:jlund)]

Comment on attachment 8830451 [details] [review]
beetmoverscript PR

with caveat inside the PR

Comment 9

[Michael Shal [:mshal]]

Comment on attachment 8830457 [details]
Bug 1333826 - Remove the make-sdk build target, the INSTALL_SDK variable, and all the supporting packager/upload machinery,

https://reviewboard.mozilla.org/r/107204/#review108670

toolkit/mozapps/installer/package-name.mk still has a SDK_PATH definition - that could go away in this patch too.

Comment 10

[Michael Shal [:mshal]]

Comment on attachment 8830459 [details]
Bug 1333826 - Remove SDK_FILES, SDK_LIBRARY, and related is_sdk support in the build goop,

https://reviewboard.mozilla.org/r/107208/#review108672

::: python/mozbuild/mozbuild/test/frontend/test_emitter.py
(Diff revision 1)
>          icons = files._children['icons']
>  
>          self.assertEqual(icons._strings, ['quux.icns'])
>  
> -    def test_sdk_files(self):
> -        reader = self.reader('sdk-files')

It looks like the python/mozbuild/mozbuild/test/frontend/data/sdk-files directory still exists - that should go away as well. (This patch removed test/backend/data/sdk-files, but not test/frontend/data/sdk-files)

Comment 11

[Michael Shal [:mshal]]

Comment on attachment 8830456 [details]
Bug 1333826 - Remove all references to MOZ_AUTOMATION_SDK,

https://reviewboard.mozilla.org/r/107202/#review108674

Comment 12

[Michael Shal [:mshal]]

Comment on attachment 8830458 [details]
Bug 1333826 - Remove SDK references from moz-automation.mk,

https://reviewboard.mozilla.org/r/107206/#review108676

Comment 13

[Michael Shal [:mshal]]

Comment on attachment 8830461 [details]
Bug 1333826 - Remove a few references from .mk files,

https://reviewboard.mozilla.org/r/107212/#review108678

Comment 14

[Michael Shal [:mshal]]

Comment on attachment 8830460 [details]
Bug 1333826 - Remove SDK references from taskcluster beetmover,

LGTM, but redirecting to :jlund since I'm not familiar with beetmover.

Comment 15

[Jordan Lund (:jlund)]

Comment on attachment 8830460 [details]
Bug 1333826 - Remove SDK references from taskcluster beetmover,

https://reviewboard.mozilla.org/r/107210/#review108866

::: taskcluster/taskgraph/transforms/beetmover.py
(Diff revision 1)
>      "target.apk",
>  ]
>  
>  
>  UPSTREAM_ARTIFACT_UNSIGNED_PATHS = {
> -    'linux64-nightly': _DESKTOP_UPSTREAM_ARTIFACTS_UNSIGNED_EN_US + [

we still need the 'linux64-nightly' and 'linux-nightly' keys and the _DESKTOP_UPSTREAM_ARTIFACTS_UNSIGNED_EN_US list of items as their value here.

Comment 16

[Jordan Lund (:jlund)]

Comment on attachment 8830460 [details]
Bug 1333826 - Remove SDK references from taskcluster beetmover,

https://reviewboard.mozilla.org/r/107210/#review108868

ugh, that was supposed to be a r- because the open issue is a blocker to landing :)

Comment 17

[Benjamin Smedberg]

Comment on attachment 8830461 [details]
Bug 1333826 - Remove a few references from .mk files,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/107212/diff/1-2/

Comment 18

[Benjamin Smedberg]

Comment on attachment 8830460 [details]
Bug 1333826 - Remove SDK references from taskcluster beetmover,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/107210/diff/1-2/

Comment 19

[Jordan Lund (:jlund)]

Comment on attachment 8830460 [details]
Bug 1333826 - Remove SDK references from taskcluster beetmover,

https://reviewboard.mozilla.org/r/107210/#review108892

lgtm

Comment 20

[Jordan Lund (:jlund)]

sorry I swore I already r+ the newest diff

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/075a7c952767
Remove SDK references from taskcluster beetmover, r=jlund
https://hg.mozilla.org/integration/mozilla-inbound/rev/3982ab8c8079
Remove all references to MOZ_AUTOMATION_SDK, r=mshal
https://hg.mozilla.org/integration/mozilla-inbound/rev/d08ce886e29c
Remove the make-sdk build target, the INSTALL_SDK variable, and all the supporting packager/upload machinery, r=mshal
https://hg.mozilla.org/integration/mozilla-inbound/rev/daa8b0da1484
Remove SDK references from moz-automation.mk, r=mshal
https://hg.mozilla.org/integration/mozilla-inbound/rev/6002440818d9
Remove SDK_FILES, SDK_LIBRARY, and related is_sdk support in the build goop, r=mshal
https://hg.mozilla.org/integration/mozilla-inbound/rev/c714a746f773
Remove a few references from .mk files, r=mshal

Comment 22

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/075a7c952767
https://hg.mozilla.org/mozilla-central/rev/3982ab8c8079
https://hg.mozilla.org/mozilla-central/rev/d08ce886e29c
https://hg.mozilla.org/mozilla-central/rev/daa8b0da1484
https://hg.mozilla.org/mozilla-central/rev/6002440818d9
https://hg.mozilla.org/mozilla-central/rev/c714a746f773

Comment 23

[Benjamin Smedberg]

Comment on attachment 8830460 [details]
Bug 1333826 - Remove SDK references from taskcluster beetmover,

Approval Request Comment
[Feature/Bug causing the regression]: not a regression
[User impact if declined]: we'll ship an unnecessary/unusable SDK with Firefox 53
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No (just build config)
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: Build config issue could cause issues with release automation if that still expects to see an SDK. Releng (jlund) believes that this is all that's necessary.

Comment 24

[Gerry Chang [:gchang]]

Comment on attachment 8830460 [details]
Bug 1333826 - Remove SDK references from taskcluster beetmover,

Remove unnecessary sdk. Aurora53+.

Comment 25

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/28160f4776bd
https://hg.mozilla.org/releases/mozilla-aurora/rev/4c673647a132
https://hg.mozilla.org/releases/mozilla-aurora/rev/0105896f2a22
https://hg.mozilla.org/releases/mozilla-aurora/rev/a10cf3a4d0e6
https://hg.mozilla.org/releases/mozilla-aurora/rev/3f30448af075
https://hg.mozilla.org/releases/mozilla-aurora/rev/935a29b0089e