1333892 - Remove PCompositorBridge::ClearCachedResources

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

http://searchfox.org/mozilla-central/rev/bf98cd4315b5efa1b28831001ad27d54df7bbb68/gfx/layers/ipc/PCompositorBridge.ipdl#136 seems to be not used anywhere. We can probably remove it safely. It was added for b2g back in bug 1154231.

Note that there is another ClearCachedResources message on PLayerTransaction which goes the other way (child -> parent) and which is still used.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

... although the CompositorBridgeChild::RecvClearCachedResources(uint64_t) function is also called directly from TabChild at [1]. Which is downright silly, because PCompositorChild just turns around calls back into TabChild. But that's evolution for ya.

[1] http://searchfox.org/mozilla-central/rev/bf98cd4315b5efa1b28831001ad27d54df7bbb68/dom/ipc/TabChild.cpp#2739

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Try push with removal: https://treeherder.mozilla.org/#/jobs?repo=try&revision=616ddcbddabafdb3c98a4bfc29e87d189aaeafd5

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1333892 - Remove unused IPC message leftover from B2G days.

Review commit: https://reviewboard.mozilla.org/r/107252/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/107252/

Comment 4

[Kan-Ru Chen [:kanru] (UTC+9)]

Comment on attachment 8830494 [details]
Bug 1333892 - Remove unused IPC message leftover from B2G days.

https://reviewboard.mozilla.org/r/107252/#review108480

Thanks!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/45009ef6d27f
Remove unused IPC message leftover from B2G days. r=kanru

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/45009ef6d27f