1333901 - document.createEvent("ErrorEvent") should work

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Per https://dom.spec.whatwg.org/#dom-document-createevent it's in the table, right?

We don't have a case for it in EventDispatcher::CreateEvent and have a comment about how new things should not be added there, but seems like either we should add it or push for a spec change or something.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Well, supported in Edge and Chrome at least, so I don't think there is reason to fight against in this trivial case.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Attachment: document_create_error_event.diff

I use the same email for alert_emails as in other cases

wpt has a test for this

https://treeherder.mozilla.org/#/jobs?repo=try&revision=87a1828542e31fcd3aa83cefd007cfa330888006

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fe6d35a774ed
support document.createEvent(ErrorEvent), r=masayuki

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0fb98449c43b
fix unexpected passes, r=me

Comment 5

[Carsten Book [:Tomcat]]

seems this caused also https://treeherder.mozilla.org/logviewer.html#?job_id=72190702&repo=mozilla-inbound for some reason and so i had to backout the changes

Comment 6

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b0a82bb74362
Backed out changeset fe6d35a774ed for causing hazard warnings after landing

Comment 7

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b14696671dcb
Backed out changeset 0fb98449c43b need also backed out to due to inital patch-backout

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/42112710614b
support document.createEvent(ErrorEvent), r=masayuki
https://hg.mozilla.org/integration/mozilla-inbound/rev/e2957aeef3ed
fix hazard issue, r=me

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/668f68822c19
fix unexpected passes, r=me

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/42112710614b
https://hg.mozilla.org/mozilla-central/rev/e2957aeef3ed
https://hg.mozilla.org/mozilla-central/rev/668f68822c19

Comment 11

[Alessio Placitelli [:Dexter]]

Please note that all new data collection requires data review:
https://wiki.mozilla.org/Firefox/Data_Collection

Comment 12

[Olli Pettay [:smaug][[e-mail]]]

This was really just a modification to the existing collection of createEvent usage.

Comment 13

[Georg Fritzsche [:gfritzsche]]

Sign-off from data-review should be rather trivial in this case then.

FWIW, this seems like it might be more useful to use one categorical histogram with the labels "dragevents", "errorevent", etc.
That would show up like this: https://mzl.la/2jK2S5n