1333916 - ICU ignores TZ env var on Windows

Status: RESOLVED WONTFIX

(Core :: JavaScript: Internationalization API, defect)

Description

[Arthur Edelstein [:arthur]]

In Tor Browser, we use the TZ env var to spoof UTC timezone. Recently this stopped working on Windows. Here is our patch that we would like to propose uplifting:

https://torpat.ch/20981

Comment 1

[Arthur Edelstein [:arthur]]

Attachment: 0001-Bug-1333916-On-Windows-check-TZ-for-timezone-first.patch

Here's a patch rebased to the latest mozilla-central.

Try results: https://treeherder.mozilla.org/#/jobs?repo=try&revision=69b211e7c52ea5ff78af4461cc22e0e56fb7d0c7

Comment 2

[Masatoshi Kimura [:emk]]

Comment on attachment 8833219 [details] [diff] [review]
0001-Bug-1333916-On-Windows-check-TZ-for-timezone-first.patch

Review of attachment 8833219 [details] [diff] [review]:
-----------------------------------------------------------------

intl/icu belongs to Core :: JS: Internationalization.
Waldo, could you review this or redirect this to another reviewer?

Comment 3

[André Bargull [:anba]]

Bug 1330149 has a version of this patch which doesn't require modifying ICU.

Comment 4

[Arthur Edelstein [:arthur]]

I opened a ticket to see if the ICU project will take the patch directly:
https://ssl.icu-project.org/trac/ticket/13130

Comment 5

[Jeff Walden [:Waldo]]

Comment on attachment 8833219 [details] [diff] [review]
0001-Bug-1333916-On-Windows-check-TZ-for-timezone-first.patch

Review of attachment 8833219 [details] [diff] [review]:
-----------------------------------------------------------------

Given upstream's hesitance to take this, and the other patch not requiring ICU changes and not seeming too implausible, I think probably this should be set aside.

Comment 6

[Jeff Walden [:Waldo]]

(Oh, sorry for the delay on this.  :-(  This has been so much an area where it felt like really grasping things would take awhile, and other work always beckoned, so I kept punting it.)