Closed
Bug 1333916
Opened 8 years ago
Closed 8 years ago
ICU ignores TZ env var on Windows
Categories
(Core :: JavaScript: Internationalization API, defect)
Core
JavaScript: Internationalization API
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: arthur, Unassigned)
References
Details
(Whiteboard: [tor][fingerprinting])
Attachments
(1 file)
694 bytes,
patch
|
Waldo
:
review-
|
Details | Diff | Splinter Review |
In Tor Browser, we use the TZ env var to spoof UTC timezone. Recently this stopped working on Windows. Here is our patch that we would like to propose uplifting: https://torpat.ch/20981
Reporter | ||
Updated•8 years ago
|
Whiteboard: [tor 20981][fingerprinting]
Reporter | ||
Comment 1•8 years ago
|
||
Here's a patch rebased to the latest mozilla-central. Try results: https://treeherder.mozilla.org/#/jobs?repo=try&revision=69b211e7c52ea5ff78af4461cc22e0e56fb7d0c7
Attachment #8833219 -
Flags: review?(VYV03354)
Comment 2•8 years ago
|
||
Comment on attachment 8833219 [details] [diff] [review] 0001-Bug-1333916-On-Windows-check-TZ-for-timezone-first.patch Review of attachment 8833219 [details] [diff] [review]: ----------------------------------------------------------------- intl/icu belongs to Core :: JS: Internationalization. Waldo, could you review this or redirect this to another reviewer?
Attachment #8833219 -
Flags: review?(VYV03354) → review?(jwalden+bmo)
Updated•8 years ago
|
Component: Internationalization → JavaScript: Internationalization API
Comment 3•8 years ago
|
||
Bug 1330149 has a version of this patch which doesn't require modifying ICU.
Reporter | ||
Comment 4•8 years ago
|
||
I opened a ticket to see if the ICU project will take the patch directly: https://ssl.icu-project.org/trac/ticket/13130
Comment 5•8 years ago
|
||
Comment on attachment 8833219 [details] [diff] [review] 0001-Bug-1333916-On-Windows-check-TZ-for-timezone-first.patch Review of attachment 8833219 [details] [diff] [review]: ----------------------------------------------------------------- Given upstream's hesitance to take this, and the other patch not requiring ICU changes and not seeming too implausible, I think probably this should be set aside.
Attachment #8833219 -
Flags: review?(jwalden+bmo) → review-
Comment 6•8 years ago
|
||
(Oh, sorry for the delay on this. :-( This has been so much an area where it felt like really grasping things would take awhile, and other work always beckoned, so I kept punting it.)
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
Reporter | ||
Updated•7 years ago
|
Whiteboard: [tor 20981][fingerprinting] → [tor][fingerprinting]
You need to log in
before you can comment on or make changes to this bug.
Description
•