1334027 - Add unloaded modules and process/thread data to minidumps

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Ting-Yu Chou [:ting] (away)]

While checking the crashes of bug 1322554, I realized that we don't have unloaded modules and TEB/PEB in minidumps, which might be helpful for debugging.  So file this bug to include MiniDumpWithUnloadedModules | MiniDumpWithProcessThreadData.

However, I am not so sure is this worth the increased dump size.

Comment 1

[Ting-Yu Chou [:ting] (away)]

Attachment: wip

The size of minidump by crashing the parent process with :bsmedberg's crashfirefox-intentionally on my Win10:

  With the WIP:    ~610KB
  Without the WIP: ~381KB

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 8830625 [details] [diff] [review]
wip

Review of attachment 8830625 [details] [diff] [review]:
-----------------------------------------------------------------

I'm fine with the concept. Maybe we should just turn it on for nightlies for a while and see what happens to the size distribution of minidumps? If they go up drastically we can always switch it off. How about wrapping this in #ifdef NIGHTLY_BUILD while we test?

FWIW, it looks like Chromium enabled these a while ago:
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-reviews/JcMDWj0OMog

I don't know if they're still using that or not.

Comment 3

[Ting-Yu Chou [:ting] (away)]

Attachment: Bug 1334027 - Add unloaded modules and process/thread data to minidumps.

Review commit: https://reviewboard.mozilla.org/r/108924/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/108924/

Comment 4

[(not currently active) Ted Mielczarek]

Comment on attachment 8832721 [details]
Bug 1334027 - Add unloaded modules and process/thread data to minidumps.

https://reviewboard.mozilla.org/r/108924/#review110274

::: toolkit/crashreporter/nsExceptionHandler.cpp:1509
(Diff revision 1)
>        if (major > 6 || (major == 6 && minor > 1) ||
>            (major == 6 && minor == 1 && revision >= 7600)) {
>          minidump_type = MiniDumpWithFullMemoryInfo;
>        }
> +#ifdef NIGHTLY_BUILD
> +      // TODO: Remove the NIGHTLY_BUILD wrapping if the increased size is

If you want to do this you should file a followup bug to track it so it doesn't get lost.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3305ef5e8faa
Add unloaded modules and process/thread data to minidumps. r=ted

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3305ef5e8faa