1334038 - <input type=date> seems to show selection pop up even when tab is changed

Status: VERIFIED FIXED

(Toolkit :: XUL Widgets, defect)

Description

[Kaartic Sivaraam]

Attachment: Screenshot showing the selector for <input type=date>

I tried to use the <input type=date> tag after enabling it using dom.forms.datetime . It looks good, but it seems that when the pop-up for selecting date is visible and when I switch to another tab "using the shortcut" Ctrl+Tab, the pop-up doesn't close instead it is shown in the new tab where it isn't relevant and also partially hiding the contents of the new tab. (see screen shots). 

Browser : Nightly 54.0a1

Steps to reproduce:
0. Enable the newly added "date" type for input tag from about:config by setting the dom.forms.datetime to true
1. Open a HTML document with <input type=date> in it
2. Click the input box to open up the date selector
3. Switch to another tab using "Ctrl+tab"

Expected behaviour:
The date selector is closed

Actual behaviour:
The selector window is shown even in the new tab where the corresponding input field isn't present

Comment 1

[Kaartic Sivaraam]

Attachment: Screenshot showing the selector for <input type=date> in switched tab

Comment 2

[Scott Wu [:scottwu]]

Attachment: Bug 1334038 - datetime pickers should close on tab switch

Review commit: https://reviewboard.mozilla.org/r/107388/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/107388/

Comment 3

[Scott Wu [:scottwu]]

Thanks for reporting this bug Kaartic!

I think all it takes is adding `tabspecific="true"` to the datetime panel:
http://searchfox.org/mozilla-central/rev/bf98cd4315b5efa1b28831001ad27d54df7bbb68/browser/base/content/browser.js#1470

Would you be able to take a quick look Mike? A similar issue happens to <select> dropdown as well. I'll file a bug if it's not reported already.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8830648 [details]
Bug 1334038 - datetime pickers should close on tab switch

https://reviewboard.mozilla.org/r/107388/#review109284

Looks good, thanks!

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Hey scottwu, thanks for the patch. For future reference, just the r? flag is fine. The additional needinfo? is not required. :)

Comment 6

[Scott Wu [:scottwu]]

Got it. Thanks Mike!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4057a8f658fc
datetime pickers should close on tab switch r=mconley

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4057a8f658fc

Comment 9

[roxleitan]

Verified as fixed using the latest Nightly 54.0a1 (2017-02-28) on Windows 10 x64, Ubuntu 16.04 and Mac OS X 10.11.