1334076 - No puzzle icon displayed in installation pop-up if there is no icon specified in manifest.json

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Vasilica Tamas, QA [:vtamas]]

Attachment: webext123-1-an+fx.xpi

[Note]
This is a follow-up bug for Bug 1317363

[Affected versions]:
Firefox 53.0a2 (2017-01-25)
Firefox 54.0a1 (2017-01-25)

[Affected platforms]:
Windows 10 64-bit
Ubuntu 16.04 32-bit


[Steps to reproduce]:
1.Launch Firefox with clean profile.
2.Create extensions.webextPermissionPrompts and set it to true.
3.Create xpinstall.signatures.dev-root and set it to true.
4.Install via sideloading flow the attached webextension. 


[Expected Results]:
The puzzle icon is displayed in installation doorhanger for those webextensions that have no icon specified in manifest.json. 


[Actual Results]:
There is no icon displayed in installation pop-up: https://www.screencast.com/t/9mdRsx4JpCzf

Comment 1

[Andrew Swan [:aswan]]

Attachment: Bug 1334076 Show default icon if necessary in sideloading notification

Also extended the sideloading test to check for icons in both
the case where the extension has an icon, and the case where it
does not.

Review commit: https://reviewboard.mozilla.org/r/107690/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/107690/

Comment 2

[Florian Quèze [:florian]]

Comment on attachment 8831033 [details]
Bug 1334076 Show default icon if necessary in sideloading notification

https://reviewboard.mozilla.org/r/107690/#review108902

I should have caught this during review :-/. Thanks for including tests in the patch! :-)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0f92d64dc0c5
Show default icon if necessary in sideloading notification r=florian

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/0f92d64dc0c5

Comment 5

[Vasilica Tamas, QA [:vtamas]]

Confirm that the add-on puzzle icon is successfully displayed in Firefox 54.0a1 (2017-01-29) under Windows 10 64-bit, Ubuntu 16.04 32-bit and Mac OS X 10.12.1: https://www.screencast.com/t/LC2UoQoUzi