1334079 - [Static Analysis][Resource leak] In function ClearKeySessionManager::CreateSession

Status: RESOLVED FIXED

(Core :: Audio/Video: GMP, defect, P2)

Description

[Andi [:andi]]

The Static Analysis tool Coverity detected that a memory leak may occur in the event when Init fails:

>>  if (!session->Init(aInitDataType, aInitData, aInitDataSize)) {
>>
>>    CK_LOGD("Failed to initialize session: %s", sessionId.c_str());
>>
>>    const static char* message = "Failed to initialize session";
>>    mHost->OnRejectPromise(aPromiseId,
>>                           Error::kUnknownError,
>>                           0,
>>                           message,
>>                           strlen(message));
>>
>>    return;
>>  }

Comment 1

[Andi [:andi]]

Attachment: Bug 1334079 - prevent memory leak in CreateSession.

Review commit: https://reviewboard.mozilla.org/r/107420/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/107420/

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8830689 [details]
Bug 1334079 - prevent memory leak in CreateSession.

https://reviewboard.mozilla.org/r/107420/#review108766

Thanks!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7450881da187
prevent memory leak in CreateSession. r=cpearce

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7450881da187