Closed
Bug 1334082
Opened 8 years ago
Closed 8 years ago
argument name 'forceAnalyze' in comment does not match parameter name 'force'
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla54
| Tracking | Status | |
|---|---|---|
| firefox54 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: barun.parruck, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug, Whiteboard: [lang=C++])
Attachments
(1 file)
I am reporting this as a source of good first bug for a beginner.
https://dxr.mozilla.org/mozilla-central/source/js/src/jsarray.cpp#3688
"forceAnalyze" should be changed to "force" to match the name of the variable in the declaration
https://dxr.mozilla.org/mozilla-central/source/js/src/vm/TypeInference.cpp#3577
| Comment hidden (mozreview-request) |
|
Assignee | |
Updated•8 years ago
|
Attachment #8831197 -
Flags: review?(sledru)
|
Reporter | |
Comment 2•8 years ago
|
||
Comment on attachment 8831197 [details]
Bug 1334082 : changes "forceAnalyze" to "force" to match variable name
Good, now, you should find an official reviewer for this patch:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction#Step_4_-_Get_your_code_reviewed
Attachment #8831197 -
Flags: review?(sledru) → feedback+
|
|
Reporter | |
Updated•8 years ago
|
Assignee: nobody → barun.parruck
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8831197 -
Flags: review?(jorendorff)
|
|
Reporter | |
Updated•8 years ago
|
Keywords: good-first-bug
Whiteboard: [good first bug][lang=C++] → [lang=C++]
|
|
Assignee | |
Comment 3•8 years ago
|
||
So I'm still waiting for a review. Should I find another reviewer or ping this one?
|
|
Reporter | |
Comment 4•8 years ago
|
||
Comment on attachment 8831197 [details]
Bug 1334082 : changes "forceAnalyze" to "force" to match variable name
Benjamin can probably help here
Attachment #8831197 -
Flags: review?(jorendorff) → review?(bbouvier)
|
||
Comment 5•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8831197 [details]
Bug 1334082 : changes "forceAnalyze" to "force" to match variable name
https://reviewboard.mozilla.org/r/107786/#review110852
Looks good to me, thanks for the patch.
Attachment #8831197 -
Flags: review?(bbouvier) → review+
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/36f46f9d8441
changes "forceAnalyze" to "force" to match variable name r=bbouvier
|
|
Reporter | |
Comment 7•8 years ago
|
||
Bravo Barun, I landed the patch for you as I have appropriate permissions.
|
||
Comment 8•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
|
|
Assignee | |
Comment 9•8 years ago
|
||
Thanks! I'll get the other bug reviewed, then start looking at something a little bit more complex.
Cheers!
You need to log in
before you can comment on or make changes to this bug.
Description
•