argument name 'forceAnalyze' in comment does not match parameter name 'force'

RESOLVED FIXED in Firefox 54

Status

()

Core
JavaScript Engine
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: sylvestre, Assigned: Barun Parruck, Mentored)

Tracking

(Blocks: 1 bug, {good-first-bug})

Trunk
mozilla54
good-first-bug
Points:
---

Firefox Tracking Flags

(firefox54 fixed)

Details

(Whiteboard: [lang=C++])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

a year ago
I am reporting this as a source of good first bug for a beginner.

https://dxr.mozilla.org/mozilla-central/source/js/src/jsarray.cpp#3688

"forceAnalyze" should be changed to "force" to match the name of the variable in the declaration
https://dxr.mozilla.org/mozilla-central/source/js/src/vm/TypeInference.cpp#3577
Comment hidden (mozreview-request)
(Assignee)

Updated

a year ago
Attachment #8831197 - Flags: review?(sledru)
(Reporter)

Comment 2

a year ago
Comment on attachment 8831197 [details]
Bug 1334082 : changes "forceAnalyze" to "force" to match variable name

Good, now, you should find an official reviewer for this patch:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction#Step_4_-_Get_your_code_reviewed
Attachment #8831197 - Flags: review?(sledru) → feedback+
(Reporter)

Updated

a year ago
Assignee: nobody → barun.parruck
(Assignee)

Updated

a year ago
Attachment #8831197 - Flags: review?(jorendorff)
(Reporter)

Updated

a year ago
Keywords: good-first-bug
Whiteboard: [good first bug][lang=C++] → [lang=C++]
(Assignee)

Comment 3

a year ago
So I'm still waiting for a review. Should I find another reviewer or ping this one?
(Reporter)

Comment 4

a year ago
Comment on attachment 8831197 [details]
Bug 1334082 : changes "forceAnalyze" to "force" to match variable name

Benjamin can probably help here
Attachment #8831197 - Flags: review?(jorendorff) → review?(bbouvier)

Comment 5

a year ago
mozreview-review
Comment on attachment 8831197 [details]
Bug 1334082 : changes "forceAnalyze" to "force" to match variable name

https://reviewboard.mozilla.org/r/107786/#review110852

Looks good to me, thanks for the patch.
Attachment #8831197 - Flags: review?(bbouvier) → review+

Comment 6

a year ago
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/36f46f9d8441
changes "forceAnalyze" to "force" to match variable name r=bbouvier
(Reporter)

Comment 7

a year ago
Bravo Barun, I landed the patch for you as I have appropriate permissions.

Comment 8

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/36f46f9d8441
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox54: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
(Assignee)

Comment 9

a year ago
Thanks! I'll get the other bug reviewed, then start looking at something a little bit more complex. 

Cheers!
You need to log in before you can comment on or make changes to this bug.