Closed Bug 1334156 Opened 4 years ago Closed 4 years ago

Replace ownerDocument.defaultView with ownerGlobal

Categories

(Firefox :: General, defect)

53 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 54
Tracking Status
firefox54 --- fixed

People

(Reporter: florian, Assigned: florian)

References

Details

Attachments

(3 files)

Attached file xpcshell script
We can simplify in most of the tree, with 2 exceptions:
- ownerGlobal isn't defined for non-privileged content code (the attached xpcshell script ignores .html and .xhtml files for this reason, and also a few .js files included by html tests)
- devtools/client (and so devtools/shared), see bug 1288071 comment 1 and bug 1288147.
These can't be handled well by my script...
Attachment #8830760 - Flags: review?(jaws)
Attachment #8830761 - Flags: review?(jaws)
Comment on attachment 8830761 [details] [diff] [review]
script-generated patch

Review of attachment 8830761 [details] [diff] [review]:
-----------------------------------------------------------------

It would be nice if we could have an eslint test for this, though I know the content vs chrome-privileged difference will make that harder to implement.

We could implement it as a rule, and then disable it for files where it doesn't exist, but that is also pretty noisy.
Attachment #8830761 - Flags: review?(jaws) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/b10f411c1481d136b7f07f928793c67b01950869
Bug 1334156 - replace ownerDocument.defaultView usages by hand in a few places, r=jaws.

https://hg.mozilla.org/integration/mozilla-inbound/rev/25c0a38d2d7ed50ed3c1d419f70c01595c481ae7
Bug 1334156 - script-generated patch to replace .ownerDocument.defaultView with .ownerGlobal, r=jaws.
https://hg.mozilla.org/mozilla-central/rev/b10f411c1481
https://hg.mozilla.org/mozilla-central/rev/25c0a38d2d7e
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
Depends on: 1338585
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/2f2c5da25817
script-generated patch to replace .ownerDocument.defaultView with .ownerGlobal, r=jaws.
You need to log in before you can comment on or make changes to this bug.