1334156 - Replace ownerDocument.defaultView with ownerGlobal

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Florian Quèze [:florian]]

Attachment: xpcshell script

We can simplify in most of the tree, with 2 exceptions:
- ownerGlobal isn't defined for non-privileged content code (the attached xpcshell script ignores .html and .xhtml files for this reason, and also a few .js files included by html tests)
- devtools/client (and so devtools/shared), see bug 1288071 comment 1 and bug 1288147.

Comment 1

[Florian Quèze [:florian]]

Attachment: changes made by hand

These can't be handled well by my script...

Comment 2

[Florian Quèze [:florian]]

Attachment: script-generated patch

Comment 3

[Florian Quèze [:florian]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=aeb0e44f6e9d

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8830761 [details] [diff] [review]
script-generated patch

Review of attachment 8830761 [details] [diff] [review]:
-----------------------------------------------------------------

It would be nice if we could have an eslint test for this, though I know the content vs chrome-privileged difference will make that harder to implement.

We could implement it as a rule, and then disable it for files where it doesn't exist, but that is also pretty noisy.

Comment 5

[Florian Quèze [:florian]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8846a9720efc

Comment 6

[Florian Quèze [:florian]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b10f411c1481d136b7f07f928793c67b01950869
Bug 1334156 - replace ownerDocument.defaultView usages by hand in a few places, r=jaws.

https://hg.mozilla.org/integration/mozilla-inbound/rev/25c0a38d2d7ed50ed3c1d419f70c01595c481ae7
Bug 1334156 - script-generated patch to replace .ownerDocument.defaultView with .ownerGlobal, r=jaws.

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b10f411c1481
https://hg.mozilla.org/mozilla-central/rev/25c0a38d2d7e

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2f2c5da25817
script-generated patch to replace .ownerDocument.defaultView with .ownerGlobal, r=jaws.