1334230 - "media.wmf.allow-unsupported-resolutions"=true disables H264 altogether

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Bug 1329824 introduced an extra pref-check before testing for supported H264 resolutions on Windows.
Unfortunately if "media.wmf.allow-unsupported-resolutions" is true, it just bypasses the whole H264-related block, including its final 'return true', so we end up disabling H264 altogether.

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1334230 - media.wmf.allow-unsupported-resolutions=true should not disable H264 -

Previously the combined tests meant that if a track was H264, and we supported
H264, BUT media.wmf.allow-unsupported-resolutions==true, we would just skip the
whole block, meaning we would return 'false' (unsupported) in the end.

Instead, if a track is H264, and we support H264, we should return 'true'
(supported), unless media.wmf.allow-unsupported-resolutions==false and the
resolution is too high.

Review commit: https://reviewboard.mozilla.org/r/107548/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/107548/

Comment 2

[Jean-Yves Avenard [:jya]]

Comment on attachment 8830859 [details]
Bug 1334230 - media.wmf.allow-unsupported-resolutions=true should not disable H264 -

https://reviewboard.mozilla.org/r/107548/#review108690

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d4df7b5bddb5
media.wmf.allow-unsupported-resolutions=true should not disable H264 - r=jya

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d4df7b5bddb5

Comment 5

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Issue in bug 1329824 landed in 53, now Aurora.

Comment 6

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8830859 [details]
Bug 1334230 - media.wmf.allow-unsupported-resolutions=true should not disable H264 -

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1329824
[User impact if declined]: "media.wmf.allow-unsupported-resolutions" is useless
[Is this code covered by automated tests?]: No, as it's an escape hatch for some power users
[Has the fix been verified in Nightly?]: Not yet
[Needs manual test from QE? If yes, steps to reproduce]: On Windows, set "media.wmf.allow-unsupported-resolutions" to true, go to youtube.com/html5 and verify that H264 is still available
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: All it does is re-establish a fallback to the pre-existing 'return true' when the pref is set to true
[String changes made/needed]: None

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8830859 [details]
Bug 1334230 - media.wmf.allow-unsupported-resolutions=true should not disable H264 -

Pref tweak to allow user control over h264, let's uplift for 53 aurora.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/13b5876f5d0c