1334287 - stylo: animation shorthand doesn't overwrite values of its longhands

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: testcase

Here's a testcase that makes me suspicious of the mochitest results in stylo in general.

Basically, setting a shorthand property should overwrite all of the longhands in that declaration block.  In this testcase, setting the 'animation' shorthand doesn't change the value of the animation-timing-function property in that declaration block.

This should print "ease-out" on the first line and "ease" on the second line, but in stylo it prints "ease-out" on both.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(Note that in Chrome it prints "initial" on the second line, which is equivalent in terms of what computed values it results in, since the initial value is "ease".)

Comment 2

[Xidorn Quan [:xidorn] UTC+10]

This is not a general issue for shorthands. Shorthands like font, border, and margin should work. Animation stuff is mostly considered unimplemented at this moment, so I'm not very surprised that it doesn't work as expected.

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Xidorn, could you please take time to confirm this?
The test case works fine now, I think your work of animation shorthand fixed this.

Comment 4

[Xidorn Quan [:xidorn] UTC+10]

Yeah, I think this has been fixed by that.

Comment 5

[Xidorn Quan [:xidorn] UTC+10]

I mean, I also confirmed that this has been fixed :)