1334309 - Ship the Large-Allocation header in Firefox 52

Status: RESOLVED WONTFIX

(Core :: DOM: Core & HTML, defect)

Description

[Nika Layzell [:nika] (ni? for response)]

This requires uplifting the changes only made in 53, and turning on the pref.

I'll be uploading patches to do that on this bug.

Patches on this bug are _not_ intended for mozilla-central, only for beta (Fx 52).

We want to ship the Large-Allocation header in Firefox 52, as that is the release which ships WASM, which we would like the header to ship alongside.

Comment 1

[Nika Layzell [:nika] (ni? for response)]

Attachment: Enable the Large-Allocation header, and bring the pref name in line with 53, r=ehsan

MozReview-Commit-ID: Ko1lf9DBTs

Comment 2

[Nika Layzell [:nika] (ni? for response)]

Attachment: (orig. 1329331) - Leave the Large-Allocation process after subsequent navigations, r=smaug

MozReview-Commit-ID: DfivmSEvzBu

Comment 3

[Nika Layzell [:nika] (ni? for response)]

Attachment: (orig. 1329331) - Add tests for not leaving the Large-Allocation process when there are other toplevel windows, r=smaug

MozReview-Commit-ID: JVM8SxleFe8

Comment 4

[Nika Layzell [:nika] (ni? for response)]

Attachment: (orig. 1332343) - Fix browser_largeAllocation.js in multi-e10s, r=smaug

MozReview-Commit-ID: EdNYf1saOI0

Comment 5

[Nika Layzell [:nika] (ni? for response)]

Attachment: (orig. 1331525) - Send the Large-Allocation success message to the correct document, r=ehsan

MozReview-Commit-ID: E44hlMI2EE3

Comment 6

[Nika Layzell [:nika] (ni? for response)]

Attachment: (orig. 1334210) - Handle Large-Allocation process exhaustion more smoothly, r=ehsan

MozReview-Commit-ID: KxnFTSXxWVi

Comment 7

[Nika Layzell [:nika] (ni? for response)]

Comment on attachment 8830950 [details] [diff] [review]
Enable the Large-Allocation header, and bring the pref name in line with 53, r=ehsan

I'd also love it if you went over the other changes in this bug to make sure I didn't make any dumb mistakes when backporting the patches to beta :).

Thanks!

Comment 8

[(no longer active)]

Comment on attachment 8830950 [details] [diff] [review]
Enable the Large-Allocation header, and bring the pref name in line with 53, r=ehsan

Review of attachment 8830950 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/ipc/ContentParent.cpp
@@ +752,5 @@
>        sLargeAllocationContentParents = new nsTArray<ContentParent*>();
>      }
>      contentParents = sLargeAllocationContentParents;
>  
> +    maxContentParents = Preferences::GetInt("dom.ipc.processCount.webLargeAllocation", 2);

You should probably use 100 as the default here as well.  This is the usual convention for reading prefs...

Comment 9

[Nika Layzell [:nika] (ni? for response)]

Attachment: Enable the Large-Allocation header, and bring the pref name in line with 53

MozReview-Commit-ID: Ko1lf9DBTs

Comment 10

[Nika Layzell [:nika] (ni? for response)]

We're not shipping the Large-Allocation header until 53 - closing this bug as WONTFIX.