1334354 - Post-install notifications are dismissed immediately if AMO redirects to a contribute page

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P1)

Description

[Andrew Swan [:aswan]]

This was originally discussed over on bug 1333071.  The problem is that if an extension has a contribute page, AMO immediately redirects the browser to that page after installing.  But with the new post-install notifications as they are currently implemented, this navigation causes the notification to be dismissed before the user has a chance to see it.
Passing the option "persistence: 1" when creating the popup prevents the notification from being dismissed in this case but it means that in other cases (installs from sites other than AMO or installs of extensions that don't have a contribute page), the notification will stick around.

Comment 1

[Andrew Swan [:aswan]]

Oops, I should have cloned the original bug.  Coyping the cc list over manually.
What do folks think, can we live with the situation described in the initial description for this bug?  (notification sticks around even if AMO doesn't navigate away)

Comment 2

[Florian Quèze [:florian]]

I'm not sure I fully understand the problem. The 'timeout' option may also be interesting, depending on what you try to do.

Comment 3

[Andrew Swan [:aswan]]

(In reply to Florian Quèze [:florian] [:flo] from comment #2)
> I'm not sure I fully understand the problem. The 'timeout' option may also
> be interesting, depending on what you try to do.

Maybe it isn't a huge problem but I was just pointing out that AMO doesn't always redirect after an install finishes (in fact, I think the redirect is the uncommon case).  So if we use the persistence option, that means the notification can remain present through another unrelated navigation.  That seems unlikely though as this notification is not "persistent" (not to be confused with "persistence") so it is likely to be dismissed pretty quickly by the user.

Comment 4

[Andy McKay]

If AMO is our main concern and they want to keep this feature, I suggest that we get AMO to change how it acts in this scenario. It doesn't have to do a redirect, it could just show something inline as soon as it gets the trigger.

Comment 5

[[e-mail]]

(In reply to Andrew Swan [:aswan] from comment #3)
> (In reply to Florian Quèze [:florian] [:flo] from comment #2)
> > I'm not sure I fully understand the problem. The 'timeout' option may also
> > be interesting, depending on what you try to do.
> 
> Maybe it isn't a huge problem but I was just pointing out that AMO doesn't
> always redirect after an install finishes (in fact, I think the redirect is
> the uncommon case).  So if we use the persistence option, that means the
> notification can remain present through another unrelated navigation.  That
> seems unlikely though as this notification is not "persistent" (not to be
> confused with "persistence") so it is likely to be dismissed pretty quickly
> by the user.

When the extensions.webextPermissionPrompts pref is false the "... has been installed successfully" doorhanger persists and is still shown when the post-install contribution page is loaded - is that implemented differently or is it timing related that it works in this scenario?

Comment 6

[Andrew Swan [:aswan]]

Ah, the existing notification uses timeout as Florian suggested in comment 2.  I didn't fully grasp what it did before but it seems like the best option here...

Comment 7

[Andrew Swan [:aswan]]

Attachment: Bug 1334354 Provide timeout for post-install notification

Review commit: https://reviewboard.mozilla.org/r/107876/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/107876/

Comment 8

[:shell escalante]

aswan said to clear

Comment 9

[Florian Quèze [:florian]]

Comment on attachment 8831320 [details]
Bug 1334354 Provide timeout for post-install notification

https://reviewboard.mozilla.org/r/107876/#review109904

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bfd5466351b0
Provide timeout for post-install notification r=florian

Comment 11

[Vasilica Tamas, QA [:vtamas]]

During Bug 1308310 testing I’ve noticed that while installing from Disco Pane the new confirmation pop-up is not so visible, because after installation, the focus is automatically changed to add-on confirmation tab. 
After returning back, the doorhanger is dismissed and I am not so sure how noticeable is the puzzle icon from toolbar: https://www.screencast.com/t/eVuSPqrecsG

Could this confirmation tab be somehow delayed in order to give enough time for permission doorhangers to be observed by users? Or is there a way to maintain displayed the pop-up though the focus is switched to another tab?

To be noticed that add-on confirmation page differs from contribution page and it is displayed in a new tab. For example DownThemAll! add-on displays both contribution and confirmation pages: https://www.screencast.com/t/iLb09izi

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/bfd5466351b0

Comment 13

[Vasilica Tamas, QA [:vtamas]]

Verified fixed on Firefox 54.0a1 (2017-02-23/24) under Windows 10 64-bit, Ubuntu 16.04 32-bit and Mac OS X 10.12.1. The Confirmation doorhanger remains displayed while AMO redirects to contribution page: https://www.screencast.com/t/YEjyaA6zmp