1334358 - Remove nsCSSFrameConstructor::CreateAnonymousFrames

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Bobby Holley (:bholley)]

Followup refactoring suggested in bug 1334247. The goal here is to send more things through AddFCItemsForAnonymousContent, since that's what we're going to hook with our style context resolution behavior in bug 1331322.

Comment 1

[Bobby Holley (:bholley)]

Here's a try push for the first part: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1270d68bcc9e93ba19dd64e6df58df6c6aa39f63

Comment 2

[Bobby Holley (:bholley)]

And here's the rest: https://treeherder.mozilla.org/#/jobs?repo=try&revision=71bdd8be07b1ed04a2672dd9378826e4d8b85287

Comment 3

[Bobby Holley (:bholley)]

Attachment: Part 1 - Stop using CreateAnonymousFrames for combo box creation. v1

Comment 4

[Bobby Holley (:bholley)]

Attachment: Part 2 - Stop using CreateAnonymousFrames for scroll frame construction and remove the now-unused helper. v1

Comment 5

[Bobby Holley (:bholley)]

(In reply to Bobby Holley (:bholley) (busy with Stylo) from comment #2)
> And here's the rest:
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=71bdd8be07b1ed04a2672dd9378826e4d8b85287

Looks green.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8831010 [details] [diff] [review]
Part 1 - Stop using CreateAnonymousFrames for combo box creation. v1

>+    AutoTArray<nsIAnonymousContentCreator::ContentInfo, 1> newAnonymousItems;

s/1/2/, right?  Because we expect it to produce two things...

r=me

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8831011 [details] [diff] [review]
Part 2 - Stop using CreateAnonymousFrames for scroll frame construction and remove the now-unused helper. v1

r=me

Comment 8

[Bobby Holley (:bholley)]

(In reply to Boris Zbarsky [:bz] (still a bit busy) from comment #6)
> Comment on attachment 8831010 [details] [diff] [review]
> Part 1 - Stop using CreateAnonymousFrames for combo box creation. v1
> 
> >+    AutoTArray<nsIAnonymousContentCreator::ContentInfo, 1> newAnonymousItems;
> 
> s/1/2/, right?  Because we expect it to produce two things...

Good catch! That was a holdover from a previous version of the patch where I altered CreateAnonymousContent to not return that item, instead of manually removing it at the caller.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f1a21a22c12b
Stop using CreateAnonymousFrames for combo box creation. r=bz
https://hg.mozilla.org/integration/mozilla-inbound/rev/314707aa7875
Stop using CreateAnonymousFrames for scroll frame construction and remove the now-unused helper. r=bz

Comment 10

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/f1a21a22c12b
https://hg.mozilla.org/mozilla-central/rev/314707aa7875