1334399 - Assertion failure: !mozilla::IsNaN(mValue.mFloat), at nsCSSValue.cpp:467

Status: RESOLVED WORKSFORME

(Core :: Web Painting, defect)

Description

[Carsten Book [:Tomcat]]

Attachment: bughunter stack

Assertion failure: !mozilla::IsNaN(mValue.mFloat), at c:/builds/moz2_slave/m-cen-w32-d-000000000000000000/build/src/layout/style/nsCSSValue.cpp:467

found via bughunter and reproduced on latest m-c tinderbox windows trunk debug build.

Steps to reproduce:
-> Load http://www.fantrax.com/fantasy/league/f35ghyqeirfp53af/home
---> Assertion failure after a few seconds 

affects beta to trunk debug builds on linux and windows

Comment 1

[Carsten Book [:Tomcat]]

[Tracking Requested - why for this release]:
debug assertion in real world website beta -> trunk debug builds



Ting-Yu, mats is this something for you ?

Comment 2

[Mats Palmgren (inactive)]

With all the mozilla::layers on the stack it seems more like Painting to me,
or possibly the style system if the bug is in StyleAnimationValue.

Comment 3

[Liz Henry (:lizzard) (relman/hg->git project)]

Matt, can you help find an owner for this? Sounds like a recent issue and it would be nice to fix in 52.

Comment 4

[Matt Woodrow (:mattwoodrow)]

Looks like an async animation bug, maybe Hiro wants to fix this?

Comment 5

[Hiroyuki Ikezoe (:hiro)]

Thank you Matt!  I can't reproduce the assertion at all (it needs to login on that site?),  but the stack apparently tells us there was a floating point calculation error.  (I guess it's caused by a cubic-bezier function?).

I could provide a patch to fix this without test case but the reduced test case would be much appreciated.

Comment 6

[Hiroyuki Ikezoe (:hiro)]

Hi Boris, would you mind trying to load the site in comment 0 and seeing if the crash happens?

Comment 7

[Boris Chiou [:boris]]

(In reply to Hiroyuki Ikezoe (:hiro) from comment #6)
> Hi Boris, would you mind trying to load the site in comment 0 and seeing if
> the crash happens?

I guess we need to sign in because I cannot reproduce it on mac and linux (nightly), and my page is re-directed to http://www.fantrax.com/login?showSignup=true

Comment 8

[Bob Clary [:bc] (inactive)]

We didn't sign in to the site in the automation either. I couldn't reproduce with a somewhat stale m-c build on fedora 25 i64. I'll clobber/build and see if I can get it to fail.

Comment 9

[Bob Clary [:bc] (inactive)]

I could not reproduce locally on Fedora 25/x86_64 nor by resubmitting the url to Bughunter. Perhaps Tomcat can find if it was fixed or simply not reproducible anymore.

Comment 10

[Julien Cristau [:jcristau]]

Doesn't look like we can fix this in time for 52.

Comment 11

[Liz Henry (:lizzard) (relman/hg->git project)]

Tomcat, is this still reproducible?
Marking this fix-optional for 53 since we're heading into late beta, we don't know if the issue still exists, and no one is assigned to it if it does.

Comment 12

[Bob Clary [:bc] (inactive)]

We saw this in production between 2017-01-26 and 2017-01-30 on two different urls. I just retested them and bughunter itself does not reproduce. I haven't checked manually however.

Comment 13

[Gerry Chang [:gchang]]

Mark 54 fix-optional but still happy to have the fix in 54.

Comment 14

[Gerry Chang [:gchang]]

[Tracking Requested - why for this release]:
Carryover the tracking flag from 54.

Comment 15

[Liz Henry (:lizzard) (relman/hg->git project)]

Since no one has been able to reproduce this since January, let's close the bug.