1334404 - Replace [name of add-on] with [your extension] / [your add-on] in permission confirmation pop-up

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P1)

Description

[Vasilica Tamas, QA [:vtamas]]

[Note]
This is a follow-up bug for Bug 1308296

[Affected versions]:
Firefox 53.0a2 (2017-01-26)
Firefox 54.0a1 (2017-01-26)

[Affected platforms]:
Windows 10 64-bit
Ubuntu 16.04 32-bit


[Steps to reproduce]:
1.Launch Firefox with clean profile.
2.Create extensions.webextPermissionPrompts and set it to true.
3.Restart the browser.
4.Navigate to https://addons.mozilla.org/en-US/firefox/addon/no-google-link-rewrite-webexts/?src=search
5.Install the webextension.


[Expected Results]:
Replace the second [name of add-on] from the confirmation pop-up with [your extension] (as is specified in mock-ups https://www.figma.com/file/HrLiKUwoLQZsIUIVBKM8Wnnu/Install-Flow-showing-Permissions) or with [your add-on] (as Scott mentioned in https://bugzilla.mozilla.org/show_bug.cgi?id=1308296#c17 )

Comment 1

[Andrew Swan [:aswan]]

Attachment: Bug 1334404 Update post-install notification message

Review commit: https://reviewboard.mozilla.org/r/107872/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/107872/

Comment 2

[Francesco Lodolo [:flod]]

Comment on attachment 8831314 [details]
Bug 1334404 Update post-install notification message

https://reviewboard.mozilla.org/r/107872/#review109108

I'm fine with this landing on central (with the string ID fixed), not really to land on Aurora where strings are frozen. Note that decision is up to release-drivers though.

There's a reason why I've been constantly nagging people about these strings at the end of previous cycle.

::: browser/locales/en-US/chrome/browser/browser.properties:132
(Diff revision 1)
> -# LOCALIZATION NOTE (addonPostInstall.message2)
> -# %1$S is replaced with the localized name of the extension.
> -# %2$S is replaced with the icon for the add-ons menu.
> +# LOCALIZATION NOTE (addonPostInstall.message2v2)
> +# %1$S is replaced with the icon for the add-ons menu.
> +# %2$S is replaced with the icon for the toolbar menu.
> -# %3$S is replaced with the icon for the toolbar menu.
>  # Note, this string will be used as raw markup. Avoid characters like <, >, &
> -addonPostInstall.message2=Manage %1$S by clicking %2$S in the %3$S menu.
> +addonPostInstall.message2v2=Manage your add-ons by clicking %1$S in the %2$S menu.

Use message3

Comment 3

[Andrew Swan [:aswan]]

Comment on attachment 8831314 [details]
Bug 1334404 Update post-install notification message

https://reviewboard.mozilla.org/r/107872/#review109108

> Use message3

Well we still have message1, this is a revision of message2, it seems strange to have message1 and message3 as the names for the two messages in a dialog...

Comment 4

[Francesco Lodolo [:flod]]

Comment on attachment 8831314 [details]
Bug 1334404 Update post-install notification message

https://reviewboard.mozilla.org/r/107872/#review109196

Comment 5

[Francesco Lodolo [:flod]]

Uh, why mozreview didn't publish the comment? Copying and pasting here for clarity.

Using 1 and 2 wasn't probably a great idea: one is a title, the other is a desc, aren't they?
If you think having 1 and 3 is confusing, you can switch to addonPostInstall.messageDesc or similar for the second string.

Comment 6

[Andrew Swan [:aswan]]

Comment on attachment 8831314 [details]
Bug 1334404 Update post-install notification message

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/107872/diff/1-2/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/edf7c9a320c2
Update post-install notification message r=flod

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/edf7c9a320c2

Comment 9

[Vasilica Tamas, QA [:vtamas]]

Confirm that this issue is fixed on Firefox 54.0a1 (2017-02-01) under Windows 10 64-bit, Ubuntu 16.04 32-bit and Mac OS X 10.12.1. Post-install notification message is successfully updated: https://www.screencast.com/t/Rmt9aTsF