1334432 - Improve GC/CC logging in multi-e10s case

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

We just report "content" in browser console for child processes' GC/CC timing when javascript.options.mem.log is set. I guess we could have content-<pid>.

(and need to also somehow reduce the number of messages, especially GC slice messages)

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Olli, were you going to write a patch for this yourself? It doesn't look like this is super high priority for us to jump on.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

I guess I should since this is rather important for any GC/CC work

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

This should be enough for me for now.

We may want to have some prefs to control whether both parent or child process logs are recorded or something. But in a different bug.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

other option is to use pid there, and not Gecko internal process id... but then, if a process dies, we don't want to reuse the id. So, Gecko id it is.

Comment 5

[Andrew McCreight [:mccr8]]

Comment on attachment 8833049 [details] [diff] [review]
patch

Review of attachment 8833049 [details] [diff] [review]:
-----------------------------------------------------------------

The normal pid might make it easier to match up to other logging, or a process monitor, but either way is fine with me.

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Attachment: getpid

This then

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/64a70b17ddeb
Improve GC/CC logging in multi-e10s, r=mccr8

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6b33c8072aae
Improve GC/CC logging in multi-e10s, r=bustage, CLOSED TREE

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7e062967c48a
Improve GC/CC logging in multi-e10s, r=bustage, CLOSED TREE

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/64a70b17ddeb
https://hg.mozilla.org/mozilla-central/rev/6b33c8072aae
https://hg.mozilla.org/mozilla-central/rev/7e062967c48a