Closed
Bug 1334432
Opened 7 years ago
Closed 7 years ago
Improve GC/CC logging in multi-e10s case
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla54
| Tracking | Status | |
|---|---|---|
| firefox54 | --- | fixed |
People
(Reporter: smaug, Assigned: smaug)
References
Details
(Whiteboard: [e10s-multi:+])
Attachments
(1 file, 1 obsolete file)
|
3.83 KB,
patch
|
mccr8
:
review+
|
Details | Diff | Splinter Review |
We just report "content" in browser console for child processes' GC/CC timing when javascript.options.mem.log is set. I guess we could have content-<pid>. (and need to also somehow reduce the number of messages, especially GC slice messages)
|
||
Updated•7 years ago
|
Whiteboard: [e10s-multi:?]
|
||
Comment 1•7 years ago
|
||
Olli, were you going to write a patch for this yourself? It doesn't look like this is super high priority for us to jump on.
Blocks: e10s-multi
Whiteboard: [e10s-multi:?] → [e10s-multi:+]
|
Assignee | |
Comment 2•7 years ago
|
||
I guess I should since this is rather important for any GC/CC work
|
|
Assignee | |
Comment 3•7 years ago
|
||
This should be enough for me for now. We may want to have some prefs to control whether both parent or child process logs are recorded or something. But in a different bug.
Assignee: nobody → bugs
Attachment #8833049 -
Flags: review?(continuation)
|
|
Assignee | |
Comment 4•7 years ago
|
||
other option is to use pid there, and not Gecko internal process id... but then, if a process dies, we don't want to reuse the id. So, Gecko id it is.
|
||
Comment 5•7 years ago
|
||
Comment on attachment 8833049 [details] [diff] [review] patch Review of attachment 8833049 [details] [diff] [review]: ----------------------------------------------------------------- The normal pid might make it easier to match up to other logging, or a process monitor, but either way is fine with me.
Attachment #8833049 -
Flags: review?(continuation) → review+
|
|
Assignee | |
Comment 6•7 years ago
|
||
This then
Attachment #8833049 -
Attachment is obsolete: true
Attachment #8833058 -
Flags: review?(continuation)
|
|
||
Updated•7 years ago
|
Attachment #8833058 -
Flags: review?(continuation) → review+
Pushed by opettay@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/64a70b17ddeb Improve GC/CC logging in multi-e10s, r=mccr8
Pushed by opettay@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/6b33c8072aae Improve GC/CC logging in multi-e10s, r=bustage, CLOSED TREE
Pushed by opettay@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/7e062967c48a Improve GC/CC logging in multi-e10s, r=bustage, CLOSED TREE
|
||
Comment 10•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/64a70b17ddeb https://hg.mozilla.org/mozilla-central/rev/6b33c8072aae https://hg.mozilla.org/mozilla-central/rev/7e062967c48a
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•