bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

Firefox Account window will be dismissed when uploading an account picture from Photo Library on iPhones

RESOLVED FIXED

Status

()

Firefox for iOS
Firefox Accounts
P2
normal
Rank:
2
RESOLVED FIXED
2 years ago
10 months ago

People

(Reporter: SimonB, Assigned: Vijay Budhram)

Tracking

(Blocks: 1 bug)

unspecified
All
iOS

Firefox Tracking Flags

(fxios-v7.0 affected, fxios10.0)

Details

(Whiteboard: [MobileCore] [FxA])

(Reporter)

Description

2 years ago
Build: 51abcc7c
Device: iPhone 7
iOS: 10.2.1

Steps to reproduce: 
1. Launch Firefox
2. Go to Settings 
3. Go to Firefox Accounts page by tapping on the email address
4. Tap on 'Add' button next to the 'Account picture' field
5. Tap 'Upload'
6. Tap 'Photo Library'

Actual results:
- The Firefox Account window is dismissed.

Expected results;
- The Photo Library should open allowing the user to select a profile picture for the Firefox Account.

Note:
- This issue is reproducible only on iPhones.
Blocks: 1337406
tracking-fxios: ? → 8.0+
Priority: -- → P3
Whiteboard: [MobileCore]
tracking-fxios: 8.0+ → 9.0
Rank: 2
Whiteboard: [MobileCore] → [MobileCore] [IOSFXA]
Priority: P3 → P2
Whiteboard: [MobileCore] [IOSFXA] → [MobileCore] [IOSFXA][papercut]
Whiteboard: [MobileCore] [IOSFXA][papercut] → [MobileCore] [FxA][papercut]
Whiteboard: [MobileCore] [FxA][papercut] → [MobileCore] [FxA]

Updated

11 months ago
Assignee: nobody → gkeeley

Updated

11 months ago
Assignee: gkeeley → vbudhram

Comment 1

11 months ago
I looked at this with Vijay. This is a bug in iOS regarding pushing a modal on the existing view hierarchy. I have dealt with similar bugs in iOS APIs in the past, the fixes will be time consuming and hacky, in particular, it will require changing the view hierarchy *just* to fix this bug for a minor new feature. This type of change will be very risky.

Apple has fixed this in iOS 11, and the vast majority of our market will be able to upgrade to it -and the remaining 10% (guessing) will not be able to change their firefox account picture using the settings. 
Our best ROI here is to either:
1) not show the row in account settings on iOS 10 for changing the picture, or 
2) not show the account settings on iOS 10

2 is a one-line fix in Swift, but as an iPhone user stuck on iOS 10, I am biased towards option 1 but I don't know offhand the difficulty level (UA works ok? Maybe pass iOS version as URL arg?)

Let's get a product level opinion
Flags: needinfo?(sarentz)
(Assignee)

Comment 2

10 months ago
Spoke with FxA team and they want disable avatar uploads on FxA content-server for iOS 10.

Ref: https://github.com/mozilla/fxa-content-server/issues/5436

Updated

10 months ago
Flags: needinfo?(sarentz)
Whiteboard: [MobileCore] [FxA] → [MobileCore] [FxA][needsuplift]

Comment 3

10 months ago
Removing the needsuplift tag and moving to 9.1. This issue will be moved server but it will probably not roll out until we have shipped 9.1.
Whiteboard: [MobileCore] [FxA][needsuplift] → [MobileCore] [FxA]

Updated

10 months ago
tracking-fxios: 9.0 → 9.1
Disabled for iOS <= 10 in https://github.com/mozilla/fxa-content-server/issues/5436
Status: NEW → RESOLVED
Last Resolved: 10 months ago
Resolution: --- → FIXED

Updated

10 months ago
tracking-fxios: 9.1 → 10.0
You need to log in before you can comment on or make changes to this bug.