Closed Bug 1334479 Opened 3 years ago Closed 3 years ago

Legacy add-ons which display a confirmation tab have no icon in confirmation doorhanger

Categories

(Toolkit :: Add-ons Manager, defect, P1)

defect

Tracking

()

VERIFIED FIXED
mozilla54
Tracking Status
firefox51 --- unaffected
firefox52 --- unaffected
firefox53 --- disabled
firefox54 --- verified

People

(Reporter: vasilica.mihasca, Assigned: aswan)

References

Details

(Keywords: regression, Whiteboard: triaged)

Attachments

(1 file)

[Affected versions]:
Firefox 53.0a2 (2017-01-25)
Firefox 54.0a1 (2017-01-27)

[Affected platforms]:
Windows 10 64-bit
Ubuntu 16.04 32-bit


[Steps to reproduce]:
1.Launch Firefox with clean profile.
2.Create extensions.webextPermissionPrompts and set it to true.
3.Restart the browser.
4.Navigate to https://addons.mozilla.org/en-US/firefox/addon/firebug/?src=cb-dl-users
5.Install the webextension.


[Expected Results]:
The add-on icon is successfully displayed in confirmation pop-up.

[Actual Results]:
- There is no icon displayed in add-on confirmation doorhanger.
- The icon appears only after dismissing and reopening the pop-up
- See screencast: https://www.screencast.com/t/tDaPK2j6

[Regression Range]:
Last good revision: 487a4e43eb9d1f04a5d8e3dd183fe38dbe105e1f
First bad revision: 160914d65dac284bba2646f52a1ce1a5aa2d22b1
Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=487a4e43eb9d1f04a5d8e3dd183fe38dbe105e1f&tochange=160914d65dac284bba2646f52a1ce1a5aa2d22b1

I suspect that this issue was regressed by Bug 1308296.
Blocks: webext-permissions
No longer blocks: 1308296
Assignee: nobody → aswan
Component: WebExtensions: Frontend → Add-ons Manager
Priority: -- → P1
Whiteboard: triaged
I'm not sure what to do here, Firebug (and I think most non-webextensions) register resource:// or chrome:// urls and use those as their icon urls, but showing that dialog races along with the extension startup so the icon may not actually be ready by the time the dialog shows up.
I don't think doing anything big here would be a worthwhile use of time, I propose we use the generic extension icon (or the one with the checkmark from the old confirmation dialog) for non-webextensions.
Markus, does that sound okay?
Flags: needinfo?(mjaritz)
If this only applies to legacy extensions, let's please use the generic extension icon with the checkmark from the old confirmation dialog if the other icon is not available.
Flags: needinfo?(mjaritz)
If this only applies to legacy extensions, let's use the generic extension icon with the checkmark from the old confirmation dialog, if the actual extension icon is not available.
I quickly tested the attached patch manually.  I'm unsure what to do about automated testing, we don't actually have any existing tests for the new post-install notifications with legacy add-ons...  Should I add a test and throw it in with everything else in browser/base/content/test/general?
Attachment #8835762 - Flags: review?(dtownsend)
Comment on attachment 8835762 [details]
Bug 1334479 Show generic icon for legacy add-ons in post-install notification

https://reviewboard.mozilla.org/r/111380/#review113490
Attachment #8835762 - Flags: review?(dtownsend) → review+
Pushed by aswan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/63524cc6ba6c
Show generic icon for legacy add-ons in post-install notification r=mossop
https://hg.mozilla.org/mozilla-central/rev/63524cc6ba6c
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Please request Aurora approval on this when you get a chance.
Flags: needinfo?(aswan)
There is no need, this issue won't appear unless a user has flipped extensions.webextPermissionPrompts, that defaults to off in Aurora.
Flags: needinfo?(aswan)
Tested on Firefox 54.0a1 (2017-02-21/22) under Windows 10 64-bit, Mac OS X 10.12.1 and Ubuntu 16.04 32-bit. Generic extension icon with the checkmark is displayed in confirmation doorhnager for all legacy extension installation even for those with an icon available - this result contradicts Comment 3.

Add-ons examples:
 - Easy screenshot: before: https://www.screencast.com/t/idv6RBIV5O and after: https://www.screencast.com/t/LxIxbbA67
 - uBlock Origin: before: https://www.screencast.com/t/LY7Pgitdn and after: https://www.screencast.com/t/1CYdLF3Gjq9m 
 - Download Youtube Videos as MP4: before: https://www.screencast.com/t/81UYjj9RjFl and after: https://www.screencast.com/t/xc4zcvf9z


Any thoughts about this?
Flags: needinfo?(aswan)
Please see comment 1, icons that come from inside extensions are not available at the time that dialog is shown so we're using the generic icon always for legacy webextensions (this matches how the previous notification worked as well for what that's worth)
Flags: needinfo?(aswan)
(In reply to Andrew Swan [:aswan] from comment #13)
> Please see comment 1, icons that come from inside extensions are not
> available at the time that dialog is shown so we're using the generic icon
> always for legacy webextensions (this matches how the previous notification
> worked as well for what that's worth)

Thanks Andrew for clarifying this! Based on Comment 12 and Comment 13 I am marking this bug as Verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.