Closed
Bug 1334513
Opened 7 years ago
Closed 7 years ago
Make sure Keyed Scalars APIs don't allow empty keys
Categories
(Toolkit :: Telemetry, defect, P1)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla54
Tracking | Status | |
---|---|---|
firefox54 | --- | fixed |
People
(Reporter: Dexter, Assigned: Dexter)
References
(Blocks 1 open bug)
Details
(Whiteboard: [measurement:client])
Attachments
(1 file, 1 obsolete file)
4.32 KB,
patch
|
gfritzsche
:
review+
|
Details | Diff | Splinter Review |
We have to make sure that we're not allowing to store keyed scalrs with empty keys.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → alessio.placitelli
Blocks: 1275517
Priority: -- → P1
Whiteboard: [measurement:client]
Assignee | ||
Comment 1•7 years ago
|
||
This patch makes the scalars print an error if an empty key is provided when changng keyed scalars.
Attachment #8831622 -
Flags: review?(gfritzsche)
Assignee | ||
Updated•7 years ago
|
Status: NEW → ASSIGNED
Comment 2•7 years ago
|
||
Comment on attachment 8831622 [details] [diff] [review] bug1334513.patch Review of attachment 8831622 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/components/telemetry/TelemetryScalar.cpp @@ +819,5 @@ > case ScalarResult::StringTooLong: > errorMessage.Append(NS_LITERAL_STRING(" - Truncating scalar value to 50 characters.")); > break; > + case ScalarResult::InvalidKeyLength: > + errorMessage.Append(NS_LITERAL_STRING(" - The key must not be empty and must be limited to 70 characters.")); I think we should have two distinct error messages here.
Attachment #8831622 -
Flags: review?(gfritzsche) → feedback+
Assignee | ||
Comment 3•7 years ago
|
||
Attachment #8831622 -
Attachment is obsolete: true
Attachment #8832032 -
Flags: review?(gfritzsche)
Updated•7 years ago
|
Attachment #8832032 -
Flags: review?(gfritzsche) → review+
Assignee | ||
Comment 4•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=91a3b51912a5
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/fbe43964eb8d Make sure Keyed Scalars APIs don't allow empty keys. r=gfritzsche
Keywords: checkin-needed
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/fbe43964eb8d
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•