Closed Bug 1334538 Opened 8 years ago Closed 8 years ago

Enable sha1 repacks and bouncer aliases in ESR52

Categories

(Release Engineering :: Release Automation: Other, defect, P1)

Product:
Release Engineering
Component:
Release Automation: Other
Type:
defect

Tracking

(firefox54 fixed)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox54 --- fixed

People

(Reporter: rail, Assigned: rail)

References

Details

Attachments

(5 files)

Bug 1334538 - Do not update SHA1 bouncer aliases in Firefox 52. a=release DONTBUILD
59 bytes, text/x-review-board-request
jlorenzo
: review+
rail
: checked-in+
Details
Bug 1334538 - Stop updating bouncer aliases in Firefox Beta 53. a=release DONTBUILD
59 bytes, text/x-review-board-request
jlorenzo
: review+
rail
: checked-in+
Details
releasetasks: Separate EME-Free and SHA1 repack logic
48 bytes, text/x-github-pull-request
jlund
: review+
Details | Review
Bug 1334538 - Pass eme_free/sha1 configs to releasetasks.
59 bytes, text/x-review-board-request
jlund
: review+
rail
: checked-in+
Details
Bug 1334538 - Separate eme_free_repacks_platforms and sha1_repacks_platforms configs
59 bytes, text/x-review-board-request
jlund
: review+
rail
: checked-in+
Details
We are going to redirect all XP new downloads to ESR52
Component: Releases → Release Automation
The first patch will be uplifted up to beta, the second one up to aurora.
Comment on attachment 8831223 [details] Bug 1334538 - Stop updating bouncer aliases in Firefox Beta 53. a=release DONTBUILD https://reviewboard.mozilla.org/r/107796/#review109208 This is coherent with bug 1290179. IIUC, thanks to this patch, we stop allowing new downloads on beta (and the next patch stops release). LGTM, then.
Attachment #8831223 - Flags: review?(jlorenzo) → review+
Comment on attachment 8831222 [details] Bug 1334538 - Do not update SHA1 bouncer aliases in Firefox 52. a=release DONTBUILD https://reviewboard.mozilla.org/r/107794/#review109210
Attachment #8831222 - Flags: review?(jlorenzo) → review+
Assignee: nobody → rail
Pushed by raliiev@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/52219cacfe87 Do not update SHA1 bouncer aliases in Firefox 52. r=jlorenzo a=release DONTBUILD https://hg.mozilla.org/integration/autoland/rev/9f4dbf7fdbdd Stop updating bouncer aliases in Firefox Beta 53. r=jlorenzo a=release DONTBUILD
Forgot to specify the keyword, still need to uplift these.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 8832949 [details] Bug 1334538 - Pass eme_free/sha1 configs to releasetasks. https://reviewboard.mozilla.org/r/109186/#review111690 looks good bar one in-line comment. could be reading wrong though. ::: buildfarm/release/releasetasks_graph_gen.py:67 (Diff revision 1) > "update_verify_enabled": release_config["update_verify_enabled"], > "push_to_candidates_enabled": release_config['push_to_candidates_enabled'], > "postrelease_bouncer_aliases_enabled": release_config['postrelease_bouncer_aliases_enabled'], > "postrelease_version_bump_enabled": release_config['postrelease_version_bump_enabled'], > "push_to_releases_automatic": release_config['push_to_releases_automatic'], > - "partner_repacks_platforms": release_config["partner_repacks_platforms"], > + "eme_free_repacks_platforms": release_config["eme_free_repacks_platforms"], hm, we want to keep partner_repacks_platforms too right?
Attachment #8832949 - Flags: review?(jlund) → review-
Attachment #8832948 - Flags: review?(jlund) → review+
Comment on attachment 8832950 [details] Bug 1334538 - Separate eme_free_repacks_platforms and sha1_repacks_platforms configs https://reviewboard.mozilla.org/r/109190/#review111692
Attachment #8832950 - Flags: review?(jlund) → review+
Comment on attachment 8832949 [details] Bug 1334538 - Pass eme_free/sha1 configs to releasetasks. https://reviewboard.mozilla.org/r/109186/#review111988 ::: buildfarm/release/releasetasks_graph_gen.py:67 (Diff revision 1) > "update_verify_enabled": release_config["update_verify_enabled"], > "push_to_candidates_enabled": release_config['push_to_candidates_enabled'], > "postrelease_bouncer_aliases_enabled": release_config['postrelease_bouncer_aliases_enabled'], > "postrelease_version_bump_enabled": release_config['postrelease_version_bump_enabled'], > "push_to_releases_automatic": release_config['push_to_releases_automatic'], > - "partner_repacks_platforms": release_config["partner_repacks_platforms"], > + "eme_free_repacks_platforms": release_config["eme_free_repacks_platforms"], Doh! Good catch!
Comment on attachment 8832949 [details] Bug 1334538 - Pass eme_free/sha1 configs to releasetasks. https://reviewboard.mozilla.org/r/109186/#review112156
Attachment #8832949 - Flags: review?(jlund) → review+
Attachment #8831222 - Flags: checked-in+
Attachment #8831223 - Flags: checked-in+
Comment on attachment 8832950 [details] Bug 1334538 - Separate eme_free_repacks_platforms and sha1_repacks_platforms configs https://hg.mozilla.org/build/buildbot-configs/rev/3cb47357583d4473d0526d5cafdc52a0f8d0d971
Attachment #8832950 - Flags: checked-in+
this is deployed now.
Everything worked fine, just need to wait until we enable esr52 and make sure we have sha1 in the configs.
Blocks: 1340263
Priority: -- → P1
(In reply to Mihai Tabara [:mtabara]⌚️GMT from comment #23) > @rail: shouldn't we turn off the uptake monitoring for sha1 here too? > https://hg.mozilla.org/releases/mozilla-beta/file/tip/testing/mozharness/ > configs/releases/bouncer_firefox_beta.py#l77 > > I see you've chained it to releases only, not betas in releasetasks > https://github.com/mozilla/releasetasks/commit/ > 0d8fda3081bffc50aabc78f727181fdd72aa586f#diff- > 70163ba31e82fd96586fb6765ed90914 Nevermind me - just noticed second patch from this bug - https://reviewboard.mozilla.org/r/107796/diff/1#index_header It will get merged on Monday anyway.
Flags: needinfo?(rail)
(In reply to Mihai Tabara [:mtabara]⌚️GMT from comment #24) > It will get merged on Monday anyway. I meant the next Monday after this Monday, the 5th of March :)
Bah, I disabled sha1 repacks, but forgot to remove the entry from https://hg.mozilla.org/releases/mozilla-beta/file/tip/testing/mozharness/configs/releases/bouncer_firefox_beta.py#l77... Sorry about that... I can land a patch or just wait until Monday. It's unlikely we are going to build another beta today/tomorrow.
(In reply to Rail Aliiev [:rail] ⌚️ET from comment #26) > Bah, I disabled sha1 repacks, but forgot to remove the entry from > https://hg.mozilla.org/releases/mozilla-beta/file/tip/testing/mozharness/ > configs/releases/bouncer_firefox_beta.py#l77... Sorry about that... I can > land a patch or just wait until Monday. It's unlikely we are going to build > another beta today/tomorrow. No worries ;) Yeah, let's leave it as it is. I'll get uplifted from aurora anyway when we do the merge.
https://tools.taskcluster.net/task-group-inspector/#/xCgWXiNNTn28rKu4QKzJBw/PbrE3yMRQb2itVDF_c6ZrQ?_k=jaspgl tells me that we add the repacks to bouncer. https://tools.taskcluster.net/task-group-inspector/#/xCgWXiNNTn28rKu4QKzJBw/lB-4EFQcS3eDznKJHrUexw?_k=75072s tells me that we schedule them. https://tools.taskcluster.net/task-group-inspector/#/xCgWXiNNTn28rKu4QKzJBw/RmVYm8ocQZaCx-aHIEcPtA?_k=utnbf3 tells me that we separate sha1 push to mirrors as expected. \o/
Status: REOPENED → RESOLVED
Closed: 8 years ago → 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: