1334679 - GTK3 menus do not display Adwaita theme arrows or ticks

Status: UNCONFIRMED

(Core :: Widget: Gtk, defect, P4)

Description

[Jonathan Rawle]

Attachment: All items from Bookmarks Toolbar onwards should have arrows pointing to a submenu

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:51.0) Gecko/20100101 Firefox/51.0
Build ID: 20170125094131

Steps to reproduce:

Start Firefox 51 on a desktop using the Adwaita GTK3 theme.


Actual results:

Menus do not display arrows indicating where there is a submenu. The submenu can still be accessed, but the arrow is missing. Any ticks used to select options in menus are also not displayed (they should appear to the left of the menu items).


Expected results:

Menus should display widgets such as arrows and tickets as they did in Firefox 50 and earlier.

Comment 1

[Jonathan Rawle]

I have tried hacking the Adwaita theme a bit. Frustratingly, as it's built into GTK3, hacking is tricky, so I had to download "Adwaita Orange" from gnome-look. This exhibits exactly the same problem.

To restore the arrows, I changed in the theme's gtk-contained.css:
    .menu .menuitem.arrow {
      -gtk-icon-source: -gtk-icontheme("pan-end-symbolic"); }

to:

    .menu .menuitem.arrow {
      -gtk-icon-source: url("/usr/share/icons/Adwaita/16x16/actions/pan-end-symbolic.symbolic.png"); }

By hard-coding the image path, this now displays arrows. It seems Firefox isn't picking up the special -gtk-icontheme path for some reason. I hope that gives a clue to someone who understands the internal workings of Firefox, which sadly I don't!

Comment 2

[Karl Tomlinson (:karlt)]

I'm not reproducing missing arrow or checks with Adwaita and GTK 3.18 or 3.20.  

There are problems with the size of the arrow in 3.18 and the shape of the arrow in 3.20, and the size of checks in 3.20 (bug 1311499).  Those are not worse in Firefox 51 than in Firefox 50.

Comment 3

[Jonathan Rawle]

U'm stuck on gtk 3.14, which is the standard in RHEL/Centos 7. It could be said that I should be using the packaged Firefox ESR they provide. This bug may affect anyone wanting to use the latest vanilla Firefox under EL7, but I accept it could be argued that it's a non-issue.

I have since fetched the Adwaita 3.14 source from GIT and patched it as described above to give a useable Firefox experience, but I feel this is a bit of a hack!

Comment 4

[john]

gtk3 3.22.10 firefox 52.0.2 can't reproduce bug

Comment 5

[rsx11m]

I can reproduce this on OpenSUSE 13.2 (default desktop theme, GTK 3.14.15; mozilla.org 52.0 build).
So, it may be a general issue with the GTK3 version not being high enough on those distributions.

Comment 6

[Jonathan Rawle]

With the recent update to RHEL/Centos 7.4, the distribution is now on gtk3-3.22.10, and I can confirm that this resolves the issue for me.