1334682 - Start trickle grace timeout only when remote candidates are available

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect, P2)

Description

[Nils Ohlmeier [:drno]]

Currently we start the trickle candidate timer as soon as offer answer concludes. That means we fire ICE failure if the remote side is not fast enough in providing its candidates.
But as long as we don't have any remote candidates there is nothing to check. So lets start this timer only when we really have received remote candidates.

BTW: should not start this timer if the SDP contained already the end-of-candidate indicator (e.g. from non-trickle implementations)?
BTW2: should we cancel this timer when we receive the end-of-candidate via trickle?

Comment 1

[Nils Ohlmeier [:drno]]

Attachment: Bug 1334682: start trickle timeout only after we have received at least on candidate.

Review commit: https://reviewboard.mozilla.org/r/107890/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/107890/

Comment 2

[Byron Campen [:bwc]]

Comment on attachment 8831330 [details]
Bug 1334682: start trickle timeout only after we have received at least on candidate.

https://reviewboard.mozilla.org/r/107890/#review109098

It looks like we will not start this timer if we get a remote trickle candidate, then offer/answer completes (and we start ICE), and then we discover our first local candidate. I guess this could happen if we're operating in no_host mode?

Comment 3

[Nils Ohlmeier [:drno]]

Comment on attachment 8831330 [details]
Bug 1334682: start trickle timeout only after we have received at least on candidate.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/107890/diff/1-2/

Comment 4

[Byron Campen [:bwc]]

Comment on attachment 8831330 [details]
Bug 1334682: start trickle timeout only after we have received at least on candidate.

https://reviewboard.mozilla.org/r/107890/#review109334

::: media/mtransport/third_party/nICEr/src/ice/ice_peer_ctx.c:439
(Diff revisions 1 - 2)
>        ABORT(r);
>  
>      if ((r = nr_ice_media_stream_pair_new_trickle_candidate(pctx, pstream, cand)))
>        ABORT(r);
>  
> +    /* Start the remote trickle grace timeout if it hasn't been started by

Remove "by"

Comment 5

[Nils Ohlmeier [:drno]]

Comment on attachment 8831330 [details]
Bug 1334682: start trickle timeout only after we have received at least on candidate.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/107890/diff/2-3/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cee7ea05a851
start trickle timeout only after we have received at least on candidate. r=bwc

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/cee7ea05a851