1334712 - Make the CSS in about:addons reusable for styling webextension options.

Status: NEW

(Toolkit :: Add-ons Manager, enhancement, P5)

Description

[Matthew Wein [:mattw]]

To style webextension options, we should be able to reuse the already existing CSS which styles the non-webextension options. I don't think it will work right off the bat, because it was probably designed with certain assumptions in mind about how the options will be displayed. Also, I think it might have some hacks in place for styling radio groups which we shouldn't need anymore.

Comment 1

[Andrew Swan [:aswan]]

I believe we already support browser_style for webextensions, is this about improving the maintainability of that?  Or something obsolete that we should just close?

Comment 2

[Blake Winton (:bwinton) (:☕️)]

I think this is about using the non-webextension styling for browser_style webextensions, which I don't think we want. It would be nice to improve the browser_style stylesheet to handle more generic html, and not require the radio group hacks, but that could be a different bug. I guess the other thought I have is that we currently have two stylesheets for the options page, the browser_style one for the extensions, and an extensions.css for the non-extension parts of the page, and it would be nice if we could reduce that to one stylesheet, or perhaps use the browser_style css in extensions.xul so that we know things are rendered consistently… But again, that might be a different bug.

Random links to things:
https://dxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/content/extensions.xul#6
https://dxr.mozilla.org/mozilla-central/source/toolkit/components/extensions/ExtensionParent.jsm#1615

Comment 3

[Geoffrey De Belie (Smile4ever)]

I think this is more about being able to integrate properly design-wise with the existing styling of the addon manager, when the option page is opened in about:addons.

For example, in the past, you were able with simple prefs (SDK) to declare preferences. They would show up as radio buttons or checkboxes in the options page, properly integrated with the rest of the page (which displays the addon details fetched from addons.mozilla.org, the author, some links).

This is something that WebExtensions currently lack. As an addon developer, you have to imitate the look of the existing grid lines, shadows and fonts to make it blend in with the rest of the Firefox addon manager GUI.

Comment 4

[Deleted Account]

(In reply to Geoffrey De Belie (Smile4ever) from comment #3)

I think this is more about being able to integrate properly design-wise with
the existing styling of the addon manager, when the option page is opened in
about:addons.

For example, in the past, you were able with simple prefs (SDK) to declare
preferences. They would show up as radio buttons or checkboxes in the
options page, properly integrated with the rest of the page (which displays
the addon details fetched from addons.mozilla.org, the author, some links).

This is something that WebExtensions currently lack. As an addon developer,
you have to imitate the look of the existing grid lines, shadows and fonts
to make it blend in with the rest of the Firefox addon manager GUI.

Blocks bug 1525178 because it removes both extensions.css files.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:mixedpuppy, could you have a look please?
For more information, please visit auto_nag documentation.