1334786 - Installer textbox is too small to display the sentences correctly

Status: VERIFIED FIXED

(Firefox :: Installer, defect, P2)

Description

[Anthony Maton [:anthony]]

Attachment: Image of the issue with the French localization

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:54.0) Gecko/20100101 Firefox/54.0
Build ID: 20170127030206

Steps to reproduce:

I launched the Installation process for Nightly on Windows 10 x64.


Actual results:

At one of the installation steps, the window is too small to fit all the translated text.
(see attached image)


Expected results:

The text box should have been bigger to allow the translated text to take the needed place.

Comment 1

[Anthony Maton [:anthony]]

I'm interested to try to fix it if it's not too complicated and if someone is willing to mentor me as I have never done anything on Firefox code.

Comment 2

[Molly Howell (she/her) (mostly inactive)]

Bug 1328445 is an unrelated change that we're testing on its own branch; this bug was actually caused by bug 797208, which rearranged the check boxes and changed the strings.

This might be a little too involved to be a good first bug; I'll work on it myself.

Comment 3

[Anthony Maton [:anthony]]

Ok, sorry for the mistake

Comment 4

[Molly Howell (she/her) (mostly inactive)]

Attachment: Bug 1334786 - Support multiple text lines for stub installer checkbox labels;

The bug only mentions the shortcuts checkbox, but the ping checkbox label looks
precariously close to also being too long, so I handled it as well.

This patch only supports up to two lines of text, and only the shortcuts and
ping checkboxes can have multiple lines. Both of those limitations could be
lifted without too much trouble, but it doesn't seem necessary for now.

Review commit: https://reviewboard.mozilla.org/r/108298/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/108298/

Comment 5

[Robert Strong (they/them - no direct email)]

Comment on attachment 8831752 [details]
Bug 1334786 - Support multiple text lines for stub installer checkbox labels;

https://reviewboard.mozilla.org/r/108298/#review109682

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0cbddad8e9dc
Support multiple text lines for stub installer checkbox labels; r=rstrong

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0cbddad8e9dc

Comment 8

[Molly Howell (she/her) (mostly inactive)]

I plan to request Aurora uplift for this patch, but I would need to verify it on a French nightly first, and those don't seem to be getting built?

Comment 9

[Francesco Lodolo [:flod]]

(In reply to Matt Howell [:mhowell] from comment #8)
> I plan to request Aurora uplift for this patch, but I would need to verify
> it on a French nightly first, and those don't seem to be getting built?

Where are you looking exactly? Plenty of localized builds, both for Aurora and Nightly
https://www.mozilla.org/fr/firefox/channel/desktop/

Comment 10

[Molly Howell (she/her) (mostly inactive)]

Okay, :flod set me straight; I was _almost_ looking in the right place, but not quite.

Comment 11

[Molly Howell (she/her) (mostly inactive)]

Comment on attachment 8831752 [details]
Bug 1334786 - Support multiple text lines for stub installer checkbox labels;

Approval Request Comment
[Feature/Bug causing the regression]:
Bug 797208

[User impact if declined]:
Cut-off strings in the stub installer French localization, and possibly others.

[Is this code covered by automated tests?]:
No.

[Has the fix been verified in Nightly?]:
Yes.

[Needs manual test from QE? If yes, steps to reproduce]: 
No, I've verified the fix myself.

[List of other uplifts needed for the feature/fix]:
None.

[Is the change risky?]:
No.

[Why is the change risky/not risky?]:
It's just a small UI change to the stub installer options page, and I've verified it to be working in both English (which doesn't trigger the new code) and French (which does).

[String changes made/needed]:
None.

Comment 12

[Gerry Chang [:gchang]]

Hello Andrei, 
could you help verify if this issue is fixed as expected on a latest Nightly build? Thanks!

Comment 13

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8831752 [details]
Bug 1334786 - Support multiple text lines for stub installer checkbox labels;

Fix for installer text, regression from 53, let's uplift it!

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/cd8688aa4efa

Comment 15

[Andrei Vaida [:avaida]]

(In reply to Gerry Chang [:gchang] from comment #12)
> Hello Andrei, 
> could you help verify if this issue is fixed as expected on a latest Nightly
> build? Thanks!

Camelia, could you please take a look at this on Nightly and Aurora?

Comment 16

[Camelia Badau [:cbadau], Desktop QA]

Attachment: auroraInstaller.png

I've tested on Windows  10 x64 on latest Nightly 54.0a1 (using the fr build from https://www.mozilla.org/fr/firefox/channel/desktop/) and on latest Aurora 53.0a2 (using the fr build from https://archive.mozilla.org/pub/firefox/nightly/latest-mozilla-aurora-l10n/): 

- if the Mozilla Maintenance Service is already installed (the "Installer le service de mise a jour en arriere-plan de Nightly/Firefox Developer Edition" option isn't displayed in the Installer textbox), all looks good - the sentences are correctly displayed in the Installer textbox

- if the Mozilla Maintenance Service isn't installed and the "Install the Firefox Developer Edition background update service"("Installer le service de mise a jour en arriere-plan de Firefox Developer Edition") option is displayed in the Installer textbox, on Aurora 53.0a2 this option isn't correctly displayed, the Installer textbox is too small. Please see attachment "auroraInstaller.png"; on Nightly 54.0a1, the option is correctly displayed.

Comment 17

[Molly Howell (she/her) (mostly inactive)]

Thanks, Camelia. I'll make a followup patch to address the maintenance service checkbox.

Comment 18

[Camelia Badau [:cbadau], Desktop QA]

Verified fixed on Windows 7 x64 and Windows 10 x64 using Firefox 53 Beta 2 (buildID: 20170313154936), fr build.