Closed Bug 1334786 Opened 3 years ago Closed 3 years ago

Installer textbox is too small to display the sentences correctly

Categories

(Firefox :: Installer, defect, P2)

54 Branch
x86
Windows 10
defect

Tracking

()

VERIFIED FIXED
Firefox 54
Tracking Status
firefox53 --- verified
firefox54 --- verified

People

(Reporter: anthony, Assigned: mhowell)

References

Details

(Keywords: nightly-community)

Attachments

(3 files)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:54.0) Gecko/20100101 Firefox/54.0
Build ID: 20170127030206

Steps to reproduce:

I launched the Installation process for Nightly on Windows 10 x64.


Actual results:

At one of the installation steps, the window is too small to fit all the translated text.
(see attached image)


Expected results:

The text box should have been bigger to allow the translated text to take the needed place.
Component: Untriaged → Installer
OS: Unspecified → Windows 10
Hardware: Unspecified → x86
Summary: Installer → Installer textbox is too small to display the sentences correctly
I'm interested to try to fix it if it's not too complicated and if someone is willing to mentor me as I have never done anything on Firefox code.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Blocks: 1328445
Bug 1328445 is an unrelated change that we're testing on its own branch; this bug was actually caused by bug 797208, which rearranged the check boxes and changed the strings.

This might be a little too involved to be a good first bug; I'll work on it myself.
Assignee: nobody → mhowell
Blocks: 797208
No longer blocks: 1328445
Priority: -- → P2
Ok, sorry for the mistake
Comment on attachment 8831752 [details]
Bug 1334786 - Support multiple text lines for stub installer checkbox labels;

https://reviewboard.mozilla.org/r/108298/#review109682
Attachment #8831752 - Flags: review?(robert.strong.bugs) → review+
Pushed by mhowell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0cbddad8e9dc
Support multiple text lines for stub installer checkbox labels; r=rstrong
https://hg.mozilla.org/mozilla-central/rev/0cbddad8e9dc
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
I plan to request Aurora uplift for this patch, but I would need to verify it on a French nightly first, and those don't seem to be getting built?
(In reply to Matt Howell [:mhowell] from comment #8)
> I plan to request Aurora uplift for this patch, but I would need to verify
> it on a French nightly first, and those don't seem to be getting built?

Where are you looking exactly? Plenty of localized builds, both for Aurora and Nightly
https://www.mozilla.org/fr/firefox/channel/desktop/
Okay, :flod set me straight; I was _almost_ looking in the right place, but not quite.
Comment on attachment 8831752 [details]
Bug 1334786 - Support multiple text lines for stub installer checkbox labels;

Approval Request Comment
[Feature/Bug causing the regression]:
Bug 797208

[User impact if declined]:
Cut-off strings in the stub installer French localization, and possibly others.

[Is this code covered by automated tests?]:
No.

[Has the fix been verified in Nightly?]:
Yes.

[Needs manual test from QE? If yes, steps to reproduce]: 
No, I've verified the fix myself.

[List of other uplifts needed for the feature/fix]:
None.

[Is the change risky?]:
No.

[Why is the change risky/not risky?]:
It's just a small UI change to the stub installer options page, and I've verified it to be working in both English (which doesn't trigger the new code) and French (which does).

[String changes made/needed]:
None.
Attachment #8831752 - Flags: approval-mozilla-aurora?
Hello Andrei, 
could you help verify if this issue is fixed as expected on a latest Nightly build? Thanks!
Flags: needinfo?(andrei.vaida)
Comment on attachment 8831752 [details]
Bug 1334786 - Support multiple text lines for stub installer checkbox labels;

Fix for installer text, regression from 53, let's uplift it!
Attachment #8831752 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(In reply to Gerry Chang [:gchang] from comment #12)
> Hello Andrei, 
> could you help verify if this issue is fixed as expected on a latest Nightly
> build? Thanks!

Camelia, could you please take a look at this on Nightly and Aurora?
Flags: needinfo?(andrei.vaida) → needinfo?(camelia.badau)
Attached image auroraInstaller.png
I've tested on Windows  10 x64 on latest Nightly 54.0a1 (using the fr build from https://www.mozilla.org/fr/firefox/channel/desktop/) and on latest Aurora 53.0a2 (using the fr build from https://archive.mozilla.org/pub/firefox/nightly/latest-mozilla-aurora-l10n/): 

- if the Mozilla Maintenance Service is already installed (the "Installer le service de mise a jour en arriere-plan de Nightly/Firefox Developer Edition" option isn't displayed in the Installer textbox), all looks good - the sentences are correctly displayed in the Installer textbox

- if the Mozilla Maintenance Service isn't installed and the "Install the Firefox Developer Edition background update service"("Installer le service de mise a jour en arriere-plan de Firefox Developer Edition") option is displayed in the Installer textbox, on Aurora 53.0a2 this option isn't correctly displayed, the Installer textbox is too small. Please see attachment "auroraInstaller.png"; on Nightly 54.0a1, the option is correctly displayed.
Flags: needinfo?(camelia.badau)
Thanks, Camelia. I'll make a followup patch to address the maintenance service checkbox.
See Also: → 1337422
Verified fixed on Windows 7 x64 and Windows 10 x64 using Firefox 53 Beta 2 (buildID: 20170313154936), fr build.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.