1334794 - nsGeolocation.cpp: redundant return statement at the end of a function with a void return type

Status: RESOLVED FIXED

(Core :: DOM: Geolocation, defect)

Description

[Sylvestre Ledru [:Sylvestre]]

A good first bug for a beginner:
here: 
https://dxr.mozilla.org/mozilla-central/source/dom/geolocation/nsGeolocation.cpp?q=nsGeolocation.cpp&redirect_type=direct#1239

The return; is useless as we are at the end of the function.

Comment 1

[Deepa]

Hi, I would like to take up this bug. I have downloaded mozilla-central. If I understand, I just have to remove the 'return' statement as pointed above. I will submit a patch as soon as possible :-)

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Sure, please upload a patch and I will assign it to you!

Comment 3

[Deepa]

Attachment: patch

Not sure how good this is, my first patch

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8832500 [details] [diff] [review]
patch

Good, now, you have to find a reviewer:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction#Step_4_-_Get_your_code_reviewed

Comment 5

[Deepa]

Hi Sylvestre, I thought to r? you, should I ask for review from someone else? If so can you suggest someone? Thanks

Comment 6

[Josh Matthews [:jdm]]

Comment on attachment 8832500 [details] [diff] [review]
patch

As a module owner for the geolocation code (https://wiki.mozilla.org/Modules/Core#Geolocation), I can review this.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/15912c8f256e
nsGeolocation.cpp: redundant return statement at the end of a function with a void return type. r=jdm

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/15912c8f256e