Closed Bug 1334794 Opened 3 years ago Closed 3 years ago
Geolocation .cpp: redundant return statement at the end of a function with a void return type
A good first bug for a beginner: here: https://dxr.mozilla.org/mozilla-central/source/dom/geolocation/nsGeolocation.cpp?q=nsGeolocation.cpp&redirect_type=direct#1239 The return; is useless as we are at the end of the function.
Whiteboard: [good first bug][lang=C++] → [lang=C++]
Hi, I would like to take up this bug. I have downloaded mozilla-central. If I understand, I just have to remove the 'return' statement as pointed above. I will submit a patch as soon as possible :-)
Sure, please upload a patch and I will assign it to you!
Not sure how good this is, my first patch
Attachment #8832500 - Flags: review?(sledru)
Comment on attachment 8832500 [details] [diff] [review] patch Good, now, you have to find a reviewer: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction#Step_4_-_Get_your_code_reviewed
Attachment #8832500 - Flags: review?(sledru) → feedback+
Hi Sylvestre, I thought to r? you, should I ask for review from someone else? If so can you suggest someone? Thanks
Comment on attachment 8832500 [details] [diff] [review] patch As a module owner for the geolocation code (https://wiki.mozilla.org/Modules/Core#Geolocation), I can review this.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/15912c8f256e nsGeolocation.cpp: redundant return statement at the end of a function with a void return type. r=jdm
You need to log in before you can comment on or make changes to this bug.