Closed Bug 1334794 Opened 3 years ago Closed 3 years ago

nsGeolocation.cpp: redundant return statement at the end of a function with a void return type

Categories

(Core :: DOM: Geolocation, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: Sylvestre, Assigned: deepsrijit1105, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [lang=C++])

Attachments

(1 file)

A good first bug for a beginner:
here: 
https://dxr.mozilla.org/mozilla-central/source/dom/geolocation/nsGeolocation.cpp?q=nsGeolocation.cpp&redirect_type=direct#1239

The return; is useless as we are at the end of the function.
Keywords: good-first-bug
Whiteboard: [good first bug][lang=C++] → [lang=C++]
Hi, I would like to take up this bug. I have downloaded mozilla-central. If I understand, I just have to remove the 'return' statement as pointed above. I will submit a patch as soon as possible :-)
Flags: needinfo?(sledru)
Sure, please upload a patch and I will assign it to you!
Flags: needinfo?(sledru)
Attached patch patchSplinter Review
Not sure how good this is, my first patch
Attachment #8832500 - Flags: review?(sledru)
Assignee: nobody → deepsrijit1105
Hi Sylvestre, I thought to r? you, should I ask for review from someone else? If so can you suggest someone? Thanks
Flags: needinfo?(sledru)
Comment on attachment 8832500 [details] [diff] [review]
patch

As a module owner for the geolocation code (https://wiki.mozilla.org/Modules/Core#Geolocation), I can review this.
Attachment #8832500 - Attachment is patch: true
Attachment #8832500 - Flags: review+
Flags: needinfo?(sledru)
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/15912c8f256e
nsGeolocation.cpp: redundant return statement at the end of a function with a void return type. r=jdm
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/15912c8f256e
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.