Closed
Bug 1334794
Opened 7 years ago
Closed 7 years ago
nsGeolocation.cpp: redundant return statement at the end of a function with a void return type
Categories
(Core :: DOM: Geolocation, defect)
Core
DOM: Geolocation
Tracking
()
RESOLVED
FIXED
mozilla54
| Tracking | Status | |
|---|---|---|
| firefox54 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: deepsrijit1105, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug, Whiteboard: [lang=C++])
Attachments
(1 file)
|
1.17 KB,
patch
|
jdm
:
review+
Sylvestre
:
feedback+
|
Details | Diff | Splinter Review |
A good first bug for a beginner: here: https://dxr.mozilla.org/mozilla-central/source/dom/geolocation/nsGeolocation.cpp?q=nsGeolocation.cpp&redirect_type=direct#1239 The return; is useless as we are at the end of the function.
|
||
Updated•7 years ago
|
Keywords: good-first-bug
Whiteboard: [good first bug][lang=C++] → [lang=C++]
Hi, I would like to take up this bug. I have downloaded mozilla-central. If I understand, I just have to remove the 'return' statement as pointed above. I will submit a patch as soon as possible :-)
Flags: needinfo?(sledru)
|
Reporter | |
Comment 2•7 years ago
|
||
Sure, please upload a patch and I will assign it to you!
Flags: needinfo?(sledru)
Not sure how good this is, my first patch
Attachment #8832500 -
Flags: review?(sledru)
|
|
Reporter | |
Updated•7 years ago
|
Assignee: nobody → deepsrijit1105
|
|
Reporter | |
Comment 4•7 years ago
|
||
Comment on attachment 8832500 [details] [diff] [review] patch Good, now, you have to find a reviewer: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction#Step_4_-_Get_your_code_reviewed
Attachment #8832500 -
Flags: review?(sledru) → feedback+
Hi Sylvestre, I thought to r? you, should I ask for review from someone else? If so can you suggest someone? Thanks
Flags: needinfo?(sledru)
|
|
||
Comment 6•7 years ago
|
||
Comment on attachment 8832500 [details] [diff] [review] patch As a module owner for the geolocation code (https://wiki.mozilla.org/Modules/Core#Geolocation), I can review this.
Attachment #8832500 -
Attachment is patch: true
Attachment #8832500 -
Flags: review+
|
|
||
Updated•7 years ago
|
Flags: needinfo?(sledru)
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/15912c8f256e nsGeolocation.cpp: redundant return statement at the end of a function with a void return type. r=jdm
Keywords: checkin-needed
|
||
Comment 8•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/15912c8f256e
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•