1334796 - StartupCache.cpp: redundant return statement at the end of a function with a void return type

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Sylvestre Ledru [:Sylvestre]]

This is a very easy good first bug for a beginner.

The following return; declaration is useless as we are at the end of the function/method
https://dxr.mozilla.org/mozilla-central/source/startupcache/StartupCache.cpp?q=StartupCache.cpp&redirect_type=direct#460

Comment 1

[Barun Parruck]

Attachment: Bug 1334796 : Removes redundant return statement in void function

Review commit: https://reviewboard.mozilla.org/r/108024/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/108024/

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8831487 [details]
Bug 1334796 : Removes redundant return statement in void function

Good, now, like the other bug, please find the appropriate reviewer.

Btw, as you are working on two super easy good first bug, please the rest to others.

Comment 3

[Barun Parruck]

Thank you, I will do that! Could you recommend a more tricky bug to resolve? :)

Comment 4

[Sylvestre Ledru [:Sylvestre]]

You will find more complex bugs here: 
https://whatcanidoformozilla.org/

Comment 5

[Nathan Froyd [:froydnj]]

Comment on attachment 8831487 [details]
Bug 1334796 : Removes redundant return statement in void function

https://reviewboard.mozilla.org/r/108024/#review110872

Thank you!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/05cc1b9c1cf1
Removes redundant return statement in void function r=froydnj

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/05cc1b9c1cf1