Closed
Bug 1334796
Opened 7 years ago
Closed 7 years ago
StartupCache.cpp: redundant return statement at the end of a function with a void return type
Categories
(Core :: General, defect)
Core
General
Tracking
()
RESOLVED
FIXED
mozilla54
| Tracking | Status | |
|---|---|---|
| firefox54 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: barun.parruck, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug, Whiteboard: [lang=C++])
Attachments
(1 file)
This is a very easy good first bug for a beginner. The following return; declaration is useless as we are at the end of the function/method https://dxr.mozilla.org/mozilla-central/source/startupcache/StartupCache.cpp?q=StartupCache.cpp&redirect_type=direct#460
|
Reporter | |
Updated•7 years ago
|
Keywords: good-first-bug
Whiteboard: [good first bug][lang=C++] → [lang=C++]
| Comment hidden (mozreview-request) |
|
|
Reporter | |
Comment 2•7 years ago
|
||
Comment on attachment 8831487 [details] Bug 1334796 : Removes redundant return statement in void function Good, now, like the other bug, please find the appropriate reviewer. Btw, as you are working on two super easy good first bug, please the rest to others.
Attachment #8831487 -
Flags: feedback+
|
|
Reporter | |
Updated•7 years ago
|
Assignee: nobody → barun.parruck
|
Assignee | |
Comment 3•7 years ago
|
||
Thank you, I will do that! Could you recommend a more tricky bug to resolve? :)
|
|
Reporter | |
Comment 4•7 years ago
|
||
You will find more complex bugs here: https://whatcanidoformozilla.org/
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8831487 -
Flags: review?(nfroyd)
|
||
Comment 5•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8831487 [details] Bug 1334796 : Removes redundant return statement in void function https://reviewboard.mozilla.org/r/108024/#review110872 Thank you!
Attachment #8831487 -
Flags: review?(nfroyd) → review+
Pushed by nfroyd@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/05cc1b9c1cf1 Removes redundant return statement in void function r=froydnj
|
||
Comment 7•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/05cc1b9c1cf1
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•