1334797 - AudioConduit.cpp: do not use 'compare' to test equality of strings; use the string equality operator instead

Status: RESOLVED INVALID

(Core :: WebRTC: Signaling, defect)

Description

[Sylvestre Ledru [:Sylvestre]]

This is a very easy good first bug for a beginner.

We should use "==" instead of compare here:
https://dxr.mozilla.org/mozilla-central/source/media/webrtc/signaling/src/media-conduit/AudioConduit.cpp?q=AudioConduit.cpp&redirect_type=direct#1058


more info: http://clang.llvm.org/extra/clang-tidy/checks/misc-string-compare.html

Comment 1

[Eric Rescorla (:ekr)]

This code appears to function correctly (it is comparing against 0, as required), so this is to some extent a matter of taste. It appears that the Mozilla style guide is silent on this topic.

sylvestre: you should probably start by proposing an adjustment to the C++ style guide. Absent that, this seems like it probably should be closed as INVALID.

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Sure, I will discuss with bsmedberg to update the C++ guide.
FWIW, we have 4 occurrences of this pattern. 3 are in unit tests (media/mtransport/test_nr_socket.cpp l144, 146 and 148), the last is this one.

Comment 3

[Eric Rescorla (:ekr)]

I do want to make clear that I don't think that this is actually something the C++ style guide should really opine on, which suggests that this change also shouldn't be made without disussion

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Just like in bug 1334265, this is just a source of good first bug :)
Invalid is fine by me. I have plenty of material others.