Closed
Bug 1334813
Opened 7 years ago
Closed 6 years ago
Should DataView.length be 1 ?
Categories
(Core :: JavaScript Engine, defect, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla65
People
(Reporter: arai, Assigned: till)
References
(Blocks 1 open bug)
Details
(Keywords: site-compat, triage-deferred)
Attachments
(1 file)
1.54 KB,
patch
|
arai
:
review+
|
Details | Diff | Splinter Review |
from https://github.com/tc39/ecma262/issues/787 According to the spec, the length of DataView constructor should be 1, however Firefox, Chrome, WebKit, and es6draft return 3. only Edge returns 1.
Updated•7 years ago
|
Keywords: triage-deferred
Priority: -- → P3
Assignee | ||
Comment 1•6 years ago
|
||
We decided on this at the current TC39 meeting. The patch is of course very straight-forward, except it changes a test262 test. When we do the next update from upstream, this change will be overwritten. The test might've been fixed by then, but if not, we'll get an additional failure. I think that's ok, because this test isn't important at all, so we shouldn't worry about it.
Reporter | ||
Comment 2•6 years ago
|
||
Comment on attachment 8960904 [details] [diff] [review] Change DataView.length from 3 to 1 Review of attachment 8960904 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!
Attachment #8960904 -
Flags: review?(arai.unmht) → review+
Comment 4•6 years ago
|
||
At this point the test262 is fixed, Arai can you just land this?
Flags: needinfo?(arai.unmht)
Pushed by arai_a@mac.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/a922413f0f74 Change DataView.length from 3 to 1. r=arai
Reporter | ||
Comment 6•6 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/a922413f0f7476f77554e94daff9ac43bb8d2e85 Bug 1334813 - Change DataView.length from 3 to 1. r=arai
Reporter | ||
Updated•6 years ago
|
Flags: needinfo?(till)
Flags: needinfo?(arai.unmht)
Comment 7•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a922413f0f74
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Pushed by evilpies@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/725d263f8a95 Enable passing test262. r=me
Comment 9•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/725d263f8a95
Comment 10•5 years ago
|
||
Posted site compatibility note: https://www.fxsitecompat.com/en-CA/docs/2018/dataview-length-is-now-1-instead-of-3/
Keywords: site-compat
You need to log in
before you can comment on or make changes to this bug.
Description
•