Closed Bug 1334813 Opened 3 years ago Closed 2 years ago

Should DataView.length be 1 ?

Categories

(Core :: JavaScript Engine, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox54 --- affected
firefox65 --- fixed

People

(Reporter: arai, Assigned: till)

References

(Blocks 1 open bug)

Details

(Keywords: site-compat, triage-deferred)

Attachments

(1 file)

from https://github.com/tc39/ecma262/issues/787

According to the spec, the length of DataView constructor should be 1,
however Firefox, Chrome, WebKit, and es6draft return 3.
only Edge returns 1.
Keywords: triage-deferred
Priority: -- → P3
We decided on this at the current TC39 meeting.

The patch is of course very straight-forward, except it changes a test262 test. When we do the next update from upstream, this change will be overwritten. The test might've been fixed by then, but if not, we'll get an additional failure. I think that's ok, because this test isn't important at all, so we shouldn't worry about it.
Assignee: nobody → till
Status: NEW → ASSIGNED
Attachment #8960904 - Flags: review?(arai.unmht)
Comment on attachment 8960904 [details] [diff] [review]
Change DataView.length from 3 to 1

Review of attachment 8960904 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8960904 - Flags: review?(arai.unmht) → review+
can you land the patch?
Flags: needinfo?(till)
Blocks: test262
At this point the test262 is fixed, Arai can you just land this?
Flags: needinfo?(arai.unmht)
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a922413f0f74
Change DataView.length from 3 to 1. r=arai
Flags: needinfo?(till)
Flags: needinfo?(arai.unmht)
https://hg.mozilla.org/mozilla-central/rev/a922413f0f74
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.