Should DataView.length be 1 ?

RESOLVED FIXED in Firefox 65

Status

()

P3
normal
RESOLVED FIXED
2 years ago
2 months ago

People

(Reporter: arai, Assigned: till)

Tracking

(Blocks: 1 bug, {site-compat, triage-deferred})

Trunk
mozilla65
site-compat, triage-deferred

Firefox Tracking Flags

(firefox54 affected, firefox65 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
from https://github.com/tc39/ecma262/issues/787

According to the spec, the length of DataView constructor should be 1,
however Firefox, Chrome, WebKit, and es6draft return 3.
only Edge returns 1.
Keywords: triage-deferred
Priority: -- → P3
(Assignee)

Comment 1

11 months ago
Created attachment 8960904 [details] [diff] [review]
Change DataView.length from 3 to 1

We decided on this at the current TC39 meeting.

The patch is of course very straight-forward, except it changes a test262 test. When we do the next update from upstream, this change will be overwritten. The test might've been fixed by then, but if not, we'll get an additional failure. I think that's ok, because this test isn't important at all, so we shouldn't worry about it.
Assignee: nobody → till
Status: NEW → ASSIGNED
Attachment #8960904 - Flags: review?(arai.unmht)
(Reporter)

Comment 2

11 months ago
Comment on attachment 8960904 [details] [diff] [review]
Change DataView.length from 3 to 1

Review of attachment 8960904 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8960904 - Flags: review?(arai.unmht) → review+
(Reporter)

Comment 3

5 months ago
can you land the patch?
Flags: needinfo?(till)
Blocks: 652780
At this point the test262 is fixed, Arai can you just land this?
Flags: needinfo?(arai.unmht)

Comment 5

3 months ago
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a922413f0f74
Change DataView.length from 3 to 1. r=arai
(Reporter)

Updated

3 months ago
Flags: needinfo?(till)
Flags: needinfo?(arai.unmht)

Comment 7

3 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a922413f0f74
Status: ASSIGNED → RESOLVED
Last Resolved: 3 months ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.