1334818 - Checker Plus for Gmail™ hangs or doesn't work due to possible regression in Fx 51

Status: RESOLVED WORKSFORME

(WebExtensions :: Untriaged, defect)

Description

[tustamido]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:51.0) Gecko/20100101 Firefox/51.0
Build ID: 20170125094131

Steps to reproduce:

mozregression:
https://hg.mozilla.org/integration/fx-team/json-pushes?changeset=b3a0aa75399dbb7da9a246082293cdd36fe05be7&full=1


Actual results:

https://addons.mozilla.org/en-US/firefox/addon/checker-plus-gmail/

Chrome extension successfully ported to Firefox stopped working in Fx 51 (release channel).

Can't open options page after install on fresh profile, so the extension doesn't work.

In my default profile, with this extension installed on Fx 50, after upgrating to 51 the chrome window hangs when I press the Checker Plus toolbar button and I can't load its options page.

Submitting here because seems to be WebExtensions regression.


Expected results:

Should work as in Fx 50 release.

Comment 1

[Loic]

Do you have a better link for the regression range, it should be something like that:
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=c0e4639e98b00f4fdb47fdbdbb6434557e7d9db7&tochange=5e045cadaa9fef76f5b5dc61a25cdd927e425486

Comment 2

[tustamido]

changeset: 6df3913433336ceaa463d831fef7c0ee5a2efa21
pushlog_url: https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=6df3913433336ceaa463d831fef7c0ee5a2efa21&tochange=1bb05a19ff9d70ed1d858d526fdbe27a8408f19f


DEBUG : Starting merge handling...
DEBUG : Using url: https://hg.mozilla.org/integration/fx-team/json-DEBUG : Found commit message:
Bug 1285493: Add-on Manager should not be closed when an add-on with options_ui is disabled. r=billm

MozReview-Commit-ID: 8oRK8uPphDf
INFO : The bisection is done.
INFO : Stopped

Comment 3

[tustamido]

oops
Using url: https://hg.mozilla.org/integration/fx-team/json-pushes?changeset=b3a0aa75399dbb7da9a246082293cdd36fe05be7&full=1

Comment 4

[Tooru Fujisawa [:arai]]

either from bug 1274775 or bug 1285493.
https://hg.mozilla.org/mozilla-central/rev/f55699ce1dbd
https://hg.mozilla.org/mozilla-central/rev/b3a0aa75399d

Comment 5

[Kris Maglione [:kmag]]

This works as expected for me in 53 and 54. Can you find out where it started working again? Something might need uplift.

Also, does this work when you install directly in Firefox 51, or does it fail only if you install in 50 and then upgrade to 51?

Comment 6

[Loic]

yes, it's already fixed. i'm searching for the fix range.

Comment 7

[tustamido]

Bug fix mozregression:

pushlog_url: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=215f9686117673a2c914ed207bc7da9bb8d741ad&tochange=9fb2ac0875ec35268701dd3826b017a301cc7400

DEBUG : Using url: https://hg.mozilla.org/mozilla-central/json-pushes?changeset=08efaee1d568cea9e70c86a7eca49c3c53553ed8&full=1
DEBUG : Found commit message:
Bug 1308440 - fix related contextMenu tests; r=Tomcat
MozReview-Commit-ID: BXBm42C1Xu

---------------------------
End of the bisection
---------------------------
Error: The url 'https://hg.mozilla.org/integration/autoland/json-pushes?fromchange=08efaee1d568cea9e70c86a7eca49c3c53553ed8&tochange=6e892f4718b09ec32f52ca90aa3e1323f0b8ac55' contains no pushlog. Maybe use another range ?

Comment 8

[Loic]

Fix range:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=1077b4771709b0df601d86e52f486d5e4345fb3f&tochange=d41feccb93b2e1dd2cb4248ae275e447be5a06f6


Fixed by bug 1302036 probably.

Comment 9

[tustamido]

(In reply to Kris Maglione [:kmag] from comment #5)
> Also, does this work when you install directly in Firefox 51, or does it
> fail only if you install in 50 and then upgrade to 51?


Installing directly in Fx 51 nothing works despite showing the toolbar button.

But having the extension installed from Fx 50, after upgrading to Fx 51 it works partially. The toolbar button and desktop notifications work, but the panel opened by toolbar button hangs Firefox badly and the extension options page doesn't load.

Comment 10

[Kris Maglione [:kmag]]

Based on that pushlog, bug 1287007 seems much more likely.

However, given the stack when I manage to trigger the freeze:

curCSS@moz-extension://8540567b-6998-4f2b-bb10-eccb964f8d6a/js/jquery.js:5570:8
.css@moz-extension://8540567b-6998-4f2b-bb10-eccb964f8d6a/js/jquery.js:6022:10
getWidthOrHeight@moz-extension://8540567b-6998-4f2b-bb10-eccb964f8d6a/js/jquery.js:5816:17
jQuery.cssHooks[name].get@moz-extension://8540567b-6998-4f2b-bb10-eccb964f8d6a/js/jquery.js:6050:6
.css@moz-extension://8540567b-6998-4f2b-bb10-eccb964f8d6a/js/jquery.js:6017:10
jQuery.fn[funcName]/<@moz-extension://8540567b-6998-4f2b-bb10-eccb964f8d6a/js/jquery.js:9132:6
jQuery.access@moz-extension://8540567b-6998-4f2b-bb10-eccb964f8d6a/js/jquery.js:3511:10
jQuery.fn[funcName]@moz-extension://8540567b-6998-4f2b-bb10-eccb964f8d6a/js/jquery.js:9107:11
getInboxViewportHeight@moz-extension://8540567b-6998-4f2b-bb10-eccb964f8d6a/js/materialDesign.js:3989:9
resizeInboxNode/</<@moz-extension://8540567b-6998-4f2b-bb10-eccb964f8d6a/js/materialDesign.js:3997:34

I suspect this may just be the extension triggering an infinite popup resize loop.

Comment 11

[tustamido]

Extension updated, 19.3.9 working fine.