1334837 - Add JSContext* to runtime for the active cooperatively scheduled thread

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Brian Hackett [Laid off!]]

Attachment: patch

The initial target for bug 1323066 is to allow JS runtimes to be cooperatively multithreaded, with at most one mutator thread operating at a time.  This patch adds an |activeContext| field for that to the runtime; since right now the runtime is single threaded, this field always points to that thread's context.

This patch also replaces most uses of UnprotectedData in the engine with ActiveThreadData (or a related class, if the data can also be accessed on a background thread), improving our thread safety checking on these fields.

Comment 1

[Brian Hackett [Laid off!]]

Attachment: runtime changes

Comment 2

[Brian Hackett [Laid off!]]

Attachment: GC changes

Comment 3

[Brian Hackett [Laid off!]]

Attachment: JIT changes

Comment 4

[Jon Coppeard (:jonco)]

Comment on attachment 8831476 [details] [diff] [review]
GC changes

Review of attachment 8831476 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.  Is there anything that exercises this functionality yet?

Comment 5

[Brian Hackett [Laid off!]]

(In reply to Jon Coppeard (:jonco) from comment #4)
> Comment on attachment 8831476 [details] [diff] [review]
> GC changes
> 
> Review of attachment 8831476 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Looks good.  Is there anything that exercises this functionality yet?

Unfortunately, there isn't.  Once the rest of the obstacles are out of the way to having a cooperatively multithreaded runtime, I'll build a shell harness to run threads cooperatively so that we can actually test this stuff.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4b8c006aff8d
Add JSContext* to runtime for the active cooperatively scheduled thread, r=jandem,jonco,h4writer.

Comment 7

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/9503e89340d9 for Mac debug crashes [@ js::CurrentThreadIsIonCompiling()] - a few devtools chunks were willing to crash that way too, but xpcshell is by far the easiest place to catch it, since every run gives you plenty of them, https://treeherder.mozilla.org/logviewer.html#?job_id=75007257&repo=mozilla-inbound

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a732f9bf1195
Add JSContext* to runtime for the active cooperatively scheduled thread, r=jandem,jonco,h4writer.

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a732f9bf1195