Closed Bug 1334845 Opened 5 years ago Closed 5 years ago

Create only one JSContext per helper thread

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla54
Tracking Flags:
Tracking Status
firefox54 --- fixed

People

(Reporter: bhackett1024, Assigned: bhackett1024)

References

Details

Attachments

(1 file)

patch
6.22 KB, patch
jandem
: review+
Details | Diff | Splinter Review
Attached patch patch — — Splinter Review 
After bug 1325050, helper threads create separate JSContexts on the stack for each task they execute.  It would be cleaner and have less overhead to use the same context throughout a helper thread's existence.  This requires mutating the context's runtime, since different tasks may be associated with different runtimes.
Attachment #8831482 - Flags: review?(jdemooij)
Assignee: nobody → bhackett1024
Blocks: 1334194
Comment on attachment 8831482 [details] [diff] [review]
patch

Review of attachment 8831482 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/vm/HelperThreads.cpp
@@ +842,5 @@
>  }
>  
> +struct MOZ_RAII AutoSetContextRuntime
> +{
> +    AutoSetContextRuntime(JSRuntime* rt) {

explicit
Attachment #8831482 - Flags: review?(jdemooij) → review+
Pushed by bhackett@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e2b893be9f4c
Create only one JSContext per helper thread, r=jandem.
https://hg.mozilla.org/mozilla-central/rev/e2b893be9f4c
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox54: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.