1334845 - Create only one JSContext per helper thread

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Brian Hackett [Laid off!]]

Attachment: patch

After bug 1325050, helper threads create separate JSContexts on the stack for each task they execute.  It would be cleaner and have less overhead to use the same context throughout a helper thread's existence.  This requires mutating the context's runtime, since different tasks may be associated with different runtimes.

Comment 1

[Jan de Mooij [:jandem]]

Comment on attachment 8831482 [details] [diff] [review]
patch

Review of attachment 8831482 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/vm/HelperThreads.cpp
@@ +842,5 @@
>  }
>  
> +struct MOZ_RAII AutoSetContextRuntime
> +{
> +    AutoSetContextRuntime(JSRuntime* rt) {

explicit

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e2b893be9f4c
Create only one JSContext per helper thread, r=jandem.

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e2b893be9f4c