1334883 - Remove code to not install maintenance service on <= Windows XP SP2

Status: RESOLVED FIXED

(Firefox :: Installer, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Because Windows XP support has been dropped.

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: Bug 1334883 - Remove code Windows XP code from installer.

Review commit: https://reviewboard.mozilla.org/r/108092/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/108092/

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: Bug 1334883 - Remove code Windows Vista code from installer.

Review commit: https://reviewboard.mozilla.org/r/108094/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/108094/

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: Bug 1334883 - Remove code NSIS pre-3.0a2 code from installer.

Review commit: https://reviewboard.mozilla.org/r/108096/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/108096/

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: Bug 1334883 - Remove code Windows XP and Vista comment about not using dde from installer.

Review commit: https://reviewboard.mozilla.org/r/108098/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/108098/

Comment 5

[Molly Howell (she/her) (mostly inactive)]

Comment on attachment 8831546 [details]
Bug 1334883 - Remove code Windows XP code from installer.

https://reviewboard.mozilla.org/r/108092/#review109396

Thanks for doing these; been wanting to get this cleanup done for a long time, and I never get around to it.

Comment 6

[Molly Howell (she/her) (mostly inactive)]

Comment on attachment 8831547 [details]
Bug 1334883 - Remove code Windows Vista code from installer.

https://reviewboard.mozilla.org/r/108094/#review109394

r+ with one issue to fix.

::: browser/installer/windows/nsis/stub.nsi:440
(Diff revision 1)
>  
>    ; The interval in MS used for the progress bars set as marquee.
> -  ${If} ${AtLeastWinVista}
> -    StrCpy $ProgressbarMarqueeIntervalMS "10"
> -  ${Else}
> -    StrCpy $ProgressbarMarqueeIntervalMS "50"
> +  StrCpy $ProgressbarMarqueeIntervalMS "50"

Kept the wrong branch here.

Comment 7

[Molly Howell (she/her) (mostly inactive)]

Comment on attachment 8831548 [details]
Bug 1334883 - Remove code NSIS pre-3.0a2 code from installer.

https://reviewboard.mozilla.org/r/108096/#review109398

Comment 8

[Molly Howell (she/her) (mostly inactive)]

Comment on attachment 8831549 [details]
Bug 1334883 - Remove code Windows XP and Vista comment about not using dde from installer.

https://reviewboard.mozilla.org/r/108098/#review109400

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2e6ee8a98405
Remove code Windows XP code from installer. r=mhowell
https://hg.mozilla.org/integration/mozilla-inbound/rev/fec112a7b6eb
Remove code Windows Vista code from installer. r=mhowell
https://hg.mozilla.org/integration/mozilla-inbound/rev/51e1a5945c30
Remove code NSIS pre-3.0a2 code from installer. r=mhowell
https://hg.mozilla.org/integration/mozilla-inbound/rev/177ca4a3129c
Remove Windows XP and Vista comment about not using dde from installer. r=mhowell

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2e6ee8a98405
https://hg.mozilla.org/mozilla-central/rev/fec112a7b6eb
https://hg.mozilla.org/mozilla-central/rev/51e1a5945c30
https://hg.mozilla.org/mozilla-central/rev/177ca4a3129c

Comment 11

[u576612]

Bug Verified [bugday-20170302]