Remove code to not install maintenance service on <= Windows XP SP2

RESOLVED FIXED in Firefox 54

Status

()

Firefox
Installer
RESOLVED FIXED
10 months ago
9 months ago

People

(Reporter: aryx, Assigned: aryx)

Tracking

unspecified
Firefox 54
Points:
---

Firefox Tracking Flags

(firefox54 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(4 attachments)

Because Windows XP support has been dropped.
Component: Application Update → Installer
Product: Toolkit → Firefox
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 5

10 months ago
mozreview-review
Comment on attachment 8831546 [details]
Bug 1334883 - Remove code Windows XP code from installer.

https://reviewboard.mozilla.org/r/108092/#review109396

Thanks for doing these; been wanting to get this cleanup done for a long time, and I never get around to it.
Attachment #8831546 - Flags: review?(mhowell) → review+

Comment 6

10 months ago
mozreview-review
Comment on attachment 8831547 [details]
Bug 1334883 - Remove code Windows Vista code from installer.

https://reviewboard.mozilla.org/r/108094/#review109394

r+ with one issue to fix.

::: browser/installer/windows/nsis/stub.nsi:440
(Diff revision 1)
>  
>    ; The interval in MS used for the progress bars set as marquee.
> -  ${If} ${AtLeastWinVista}
> -    StrCpy $ProgressbarMarqueeIntervalMS "10"
> -  ${Else}
> -    StrCpy $ProgressbarMarqueeIntervalMS "50"
> +  StrCpy $ProgressbarMarqueeIntervalMS "50"

Kept the wrong branch here.
Attachment #8831547 - Flags: review?(mhowell) → review+

Comment 7

10 months ago
mozreview-review
Comment on attachment 8831548 [details]
Bug 1334883 - Remove code NSIS pre-3.0a2 code from installer.

https://reviewboard.mozilla.org/r/108096/#review109398
Attachment #8831548 - Flags: review?(mhowell) → review+

Comment 8

10 months ago
mozreview-review
Comment on attachment 8831549 [details]
Bug 1334883 - Remove code Windows XP and Vista comment about not using dde from installer.

https://reviewboard.mozilla.org/r/108098/#review109400
Attachment #8831549 - Flags: review?(mhowell) → review+

Comment 9

10 months ago
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2e6ee8a98405
Remove code Windows XP code from installer. r=mhowell
https://hg.mozilla.org/integration/mozilla-inbound/rev/fec112a7b6eb
Remove code Windows Vista code from installer. r=mhowell
https://hg.mozilla.org/integration/mozilla-inbound/rev/51e1a5945c30
Remove code NSIS pre-3.0a2 code from installer. r=mhowell
https://hg.mozilla.org/integration/mozilla-inbound/rev/177ca4a3129c
Remove Windows XP and Vista comment about not using dde from installer. r=mhowell

Comment 10

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/2e6ee8a98405
https://hg.mozilla.org/mozilla-central/rev/fec112a7b6eb
https://hg.mozilla.org/mozilla-central/rev/51e1a5945c30
https://hg.mozilla.org/mozilla-central/rev/177ca4a3129c
Status: ASSIGNED → RESOLVED
Last Resolved: 10 months ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54

Updated

10 months ago
Blocks: 1335344

Comment 11

9 months ago
Bug Verified [bugday-20170302]
You need to log in before you can comment on or make changes to this bug.