1335000 - [Static Analysis] Operator= should return a OwningUnrestrictedDoubleOrString&

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Andi [:andi]]

Codechecker detected that operator= should return a OwningUnrestrictedDoubleOrString&
https://dxr.mozilla.org/mozilla-central/source/obj-x86_64-pc-linux-gnu/dist/include/mozilla/dom/UnionTypes.h#14247

By having it return void we suppress the usage of expressions like:

a = b = c

Comment 1

[Andi [:andi]]

Attachment: Bug 1335000 - return type& for copy assignment operator.

Review commit: https://reviewboard.mozilla.org/r/108240/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/108240/

Comment 2

[Peter Van der Beken [:peterv]]

Comment on attachment 8831684 [details]
Bug 1335000 - return type& for copy assignment operator.

https://reviewboard.mozilla.org/r/108240/#review109894

::: dom/bindings/Codegen.py:10230
(Diff revision 1)
>                          bodyInHeader=True,
>                          visibility="public",
>                          explicit=True,
>                          body="*this = aOther;\n"))
> +                op_body=CGSwitch("aOther.mType", assignmentCases);
> +                op_body.append(CGGeneric("return *this;\n"));

This seems wrong, CGSwitch being a list is an implementation detail. Please create your own CGList containing the CGSwitch and the CGGeneric.

Comment 3

[Andi [:andi]]

Comment on attachment 8831684 [details]
Bug 1335000 - return type& for copy assignment operator.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/108240/diff/1-2/

Comment 4

[Peter Van der Beken [:peterv]]

Comment on attachment 8831684 [details]
Bug 1335000 - return type& for copy assignment operator.

https://reviewboard.mozilla.org/r/108240/#review113402

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/65b1e4b706e2
return type& for copy assignment operator. r=peterv

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/65b1e4b706e2