Open Bug 1335073 Opened 6 years ago Updated 8 months ago
The fake DOM API in JSDOMParser
.js should implement node .remove()
(Toolkit :: Reader Mode, defect, P3)
(Reporter: florian, Unassigned)
3.54 KB, patch
|Details | Diff | Splinter Review|
In bug 1334831 I had to exclude toolkit/components/reader/Readability.js and toolkit/components/reader/JSDOMParser.js because using .remove instead of .parentNode.removeChild fails there (and caused several test failures). The fix seems straightforward: JSDOMParser.js should implement the 'remove' method. I'm attaching the part of the script generated patch that didn't land in bug 1334831 due to this bug. Note that we added an eslint rule to report usage of parentNode.removeChild, so whenever eslint gets enabled in m-c for these 2 files (bug 1314570), this will get reported.
6 years ago
Priority: -- → P3
8 months ago
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.