1335164 - websocketprocessbridge should be installed conditionally based on a more specific test

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Chris Manchester (limited bugmail, email directly)]

Right now we're doing it based on the presence of a "mochitest" directory on the tester. So if we re-organize the test archives, it might break.

Comment 1

[Chris Manchester (limited bugmail, email directly)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b53ae85d3361c59bd6490b99a08fec85e4b014f5

Comment 2

[Chris Manchester (limited bugmail, email directly)]

Attachment: Bug 1335164 - Install websocketprocessbridge with a more specific test.

Review commit: https://reviewboard.mozilla.org/r/108342/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/108342/

Comment 3

[Byron Campen [:bwc]]

Comment on attachment 8831820 [details]
Bug 1335164 - Install websocketprocessbridge with a more specific test.

https://reviewboard.mozilla.org/r/108342/#review109448

It looks fine to me, but I'm not a peer on the test harness stuff. Not sure if I can r+ for this code.

Comment 4

[Jordan Lund (:jlund)]

Comment on attachment 8831820 [details]
Bug 1335164 - Install websocketprocessbridge with a more specific test.

https://reviewboard.mozilla.org/r/108342/#review109606

::: testing/mozharness/scripts/android_emulator_unittest.py:176
(Diff revision 1)
>      def _pre_create_virtualenv(self, action):
>          dirs = self.query_abs_dirs()
>          requirements = None
> -        if os.path.isdir(dirs['abs_mochitest_dir']):
> -            # mochitest is the only thing that needs this
> +        if self.test_suite == 'mochitest-media':
> +            # mochitest-media is the only thing that needs this
>              requirements = os.path.join(dirs['abs_mochitest_dir'],

iiuc, we are still relying on the presence of the mochitest dir for this right? Is the goal to simply reduce the amount of times we install websocketprocessbridge to suites that actually need it?

Comment 5

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8831820 [details]
Bug 1335164 - Install websocketprocessbridge with a more specific test.

https://reviewboard.mozilla.org/r/108342/#review109606

> iiuc, we are still relying on the presence of the mochitest dir for this right? Is the goal to simply reduce the amount of times we install websocketprocessbridge to suites that actually need it?

Right, we need that directory if we're trying to run mochitests. The issue is that we're trying to re-organize the test archives a bit, and it will no longer be the case that the existence of the "mochitest" directory implies the existence of the "mochitest/websocketprocessbridge" directory, as seen attempting to land bug 1330421.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d4d8cfdd6a7b
Install websocketprocessbridge with a more specific test. r=jlund

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d4d8cfdd6a7b