1335196 - role-centric view on Permissions page

Status: RESOLVED FIXED

(Release Engineering Graveyard :: Applications: Balrog (frontend), defect, P3)

Description

[[e-mail] (:bhearsum)]

UI for User Roles was recently added to the Permissions page. It's working well for managing Roles on Users, but we could really do with another section there that shows us Roles, and who belongs to each.

Comment 1

[Obinna Okwuolisa]

Hi Ben, are there any valid list of roles? I noticed any role can be added and a user can have more than one roles.

Comment 2

[[e-mail] (:bhearsum)]

(In reply to Obinna Okwuolisa from comment #1)
> Hi Ben, are there any valid list of roles? I noticed any role can be added
> and a user can have more than one roles.

That's correct - a Role is just a string. There's no hardcoded set of valid Roles.

Comment 3

[Obinna Okwuolisa]

Attachment: roles page mock up

Hi Ben, here is a mock up for the roles page I intend implementing. Please give your feedback.

Comment 4

[[e-mail] (:bhearsum)]

(In reply to Obinna Okwuolisa from comment #3)
> Created attachment 8907749 [details]
> roles page mock up
> 
> Hi Ben, here is a mock up for the roles page I intend implementing. Please
> give your feedback.

Sorry for the delay in response. That looks good! My only suggestion would be to use "All Roles" instead of "Roles" as the default in the drop down.

We also need to decide where to link this up in the UI - perhaps another item in the hover menu for "Permissions"? Or a link from within the Permissions page?

Comment 5

[Obinna Okwuolisa]

Okay. Another menu under "Permissions" will be nice.

Comment 6

[[github robot]]

Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/d2fc7335e27e62f70669d8f8d71560c4557203fb
Bug 1335196: Role-centric view on Permissions page (#417). r=bhearsum

Comment 7

[[e-mail] (:bhearsum)]

This is in production - thank you Obinna!