1335206 - Emit new SCTP data channel offer format in Fx >= 62

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, defect, P3)

Description

[Nils Ohlmeier [:drno]]

So far Fx puts sctp-sdp-05 format into its SDP offers. Bug 1160558 adds support for parsing and answering sctp-sdp-21 format.

But Chrome currently does not properly answer sctp-sdp-21 offers. Once https://bugs.chromium.org/p/chromium/issues/detail?id=686212 has been fixed and rolled out to release we should turn on offering the new format by updating SdpHelper::GetProtocolForMediaType()

Once done this should also be documented via public announcements and updating our documentation.

Comment 1

[Nils Ohlmeier [:drno]]

Chrome supports now parsing and responding to new offer in 58.

But as bug 1160558 landed in 53 we missed the 52 ESR release. To prevent incompatibility between recent Firefox and ESR we need to wait until the next 52 ESR is gone, which would be at earliest when 59 rolls out, but probably even later.

Comment 2

[Bulk Bug Changes for mreavy's org]

Mass change P2->P3 to align with new Mozilla triage process.

Comment 3

[Nils Ohlmeier [:drno]]

https://wiki.mozilla.org/RapidRelease/Calendar

Since Fx 60 is going to be the next ESR release we should probably wait until after 52.9 ESR, which puts us at 62.

Comment 4

[Nils Ohlmeier [:drno]]

Attachment: Bug 1335206: enable emitting datachannel draft 21 format.

Review commit: https://reviewboard.mozilla.org/r/252478/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/252478/

Comment 5

[Nils Ohlmeier [:drno]]

Tested on sharedrop.io that data channel interoperability with Chrome 67 works in both directions.

Comment 6

[Nils Ohlmeier [:drno]]

Comment on attachment 8987223 [details]
Bug 1335206: enable emitting datachannel draft 21 format.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/252478/diff/1-2/

Comment 7

[Byron Campen [:bwc]]

Comment on attachment 8987223 [details]
Bug 1335206: enable emitting datachannel draft 21 format.

https://reviewboard.mozilla.org/r/252478/#review259658

Just make sure to test with ESR I guess.

::: media/webrtc/signaling/gtest/jsep_session_unittest.cpp:1491
(Diff revision 2)
> +        if (msection.GetProtocol() == SdpMediaSection::kUdpDtlsSctp ||
> +            msection.GetProtocol() == SdpMediaSection::kTcpDtlsSctp) {
> +          // draft 21 format
> +          ASSERT_EQ(SdpMediaSection::kUdpDtlsSctp, msection.GetProtocol());
> +        } else {

This check seems a little silly.

Comment 8

[Nils Ohlmeier [:drno]]

Comment on attachment 8987223 [details]
Bug 1335206: enable emitting datachannel draft 21 format.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/252478/diff/2-3/

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ca719d248391
enable emitting datachannel draft 21 format. r=bwc

Comment 10

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/ca719d248391

Comment 11

[Eric Shepherd [:sheppy]]

Presumably all we need to do is note the support for the new format. Are any older formats removed?

Comment 12

[Eric Shepherd [:sheppy]]

Added a new section to the RTCDataChannel page that briefly mentions the underlying format and that it’s changed over time:

https://developer.mozilla.org/en-US/docs/Web/API/RTCDataChannel#Data_format

Also submitted PR #2615 to add a new row to the compat tables indicating support for the new format.

Updated Firefox 63 for developers.

Comment 13

[Nils Ohlmeier [:drno]]

(In reply to Eric Shepherd [:sheppy] from comment #12)
> https://developer.mozilla.org/en-US/docs/Web/API/RTCDataChannel#Data_format

Looks good to me.

Firefox still supports the old format and will answer with the old format if the offer came in with the old format.