Closed
Bug 1335268
Opened 7 years ago
Closed 2 years ago
Reader View do not detect language of webpage properly.
Categories
(Toolkit :: Reader Mode, defect, P3)
Tracking
()
RESOLVED
DUPLICATE
of bug 1474565
People
(Reporter: towlyhk-mozilla, Unassigned)
Details
(Whiteboard: [about-reader-ui] )
User Agent: Mozilla/5.0 (Windows NT 6.1; rv:50.0) Gecko/20100101 Firefox/50.0 Build ID: 20161210192100 Steps to reproduce: One Windows, Reader View display some Chinese webpage properly (eg. http://zh.wikipedia.org/). But display of some other Chinese webpage is ugly, for example, http://baike.baidu.com/subview/27059/27059.htm https://news.gamme.com.tw/1432245 Actual results: In the same paragraph some Chinese characters are displayed in odd style (bold truetype or bold raster font). The result may depend on the default system locale and default system font. But, if add a lang="zh-CN" or lang="zh-TW" attribute to the <html> tag, it will use the fonts defined in about:preferences#content and look much better. Expected results: Reader View should detect language of webpage and choose the best font to use. Or just copy the lang attribute of <html> tag from the source webpage. This may not be correct for website has different language for different article, as the cms use the same lang attribute for all pages. But this usually have better result than current's language detector for many other webpages.
Reporter | ||
Updated•7 years ago
|
Whiteboard: [about-reader-ui]
Reporter | ||
Updated•7 years ago
|
OS: Unspecified → Windows
Hardware: Unspecified → All
Can you provide a detailed STR? I don't see the reader icon appear in urlbar, and that looks good through add the about:reader?url= into url to opened.
Component: Untriaged → Reader Mode
Flags: needinfo?(towlyhk-mozilla)
Product: Firefox → Toolkit
Reporter | ||
Comment 2•7 years ago
|
||
I'm sorry, I forgot I added style to userChrome.css to always show the Reader View icon. #reader-mode-button { display: block !important; visibility:visible !important;} The following are some other links that will show Reader View icon. And some screen captures that show the problem. Capture1: http://imagizer.imageshack.us/a/img922/2083/09i0Vl.png Capture2: http://imagizer.imageshack.us/a/img923/6065/BRSphf.png https://www.thenewslens.com/article/60344 Capture3: http://imagizer.imageshack.us/a/img922/5849/iryRkR.png https://unwire.pro/2016/05/25/a-lot-of-people-still-dont-know-what-ransomware-is/security/ Caputure4: http://imagizer.imageshack.us/a/img923/3162/uAK88i.png https://hk.news.yahoo.com/同道中人湧港犯險-攻頂-危攝追求亡命感覺-231800602.html Capture5: http://imagizer.imageshack.us/a/img924/5974/aGnvRx.png Captures: https://goo.gl/photos/dQDjgCgQ8EMqLQRY6 .
I can't reproduce this situation. Can you use an new profile to reproduce it? Or, you may need to turn off hardware acceleration in Options.
Component: Reader Mode → Untriaged
Product: Toolkit → Firefox
Reporter | ||
Comment 4•7 years ago
|
||
I turned off hardware acceleration. But still the same problem.
Flags: needinfo?(towlyhk-mozilla)
Comment 5•7 years ago
|
||
Build ID: 20170205030206 User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:54.0) Gecko/20100101 Firefox/54.0 Tested on Windows 10 x 64 on Firefox 51.0.1, Firefox 50.0 and on Firefox Nightly 54.0a1 and it's reproducible.
Status: UNCONFIRMED → NEW
status-firefox51:
--- → affected
status-firefox52:
--- → affected
status-firefox53:
--- → affected
status-firefox54:
--- → affected
Component: Untriaged → Reader Mode
Ever confirmed: true
OS: Windows → All
Product: Firefox → Toolkit
Hardware: All → x86
Comment 6•7 years ago
|
||
I can see reader mode button for the two pages[1][2] listed on Comment 2. But my result looks good. I tested it on Firefox 51.0.1 on Mac OS. So the issue only occurred on Windows? I'll try my Windows 10 machine later. [1]: https://unwire.pro/2016/05/25/a-lot-of-people-still-dont-know-what-ransomware-is/security/ [2]: https://hk.news.yahoo.com/同道中人湧港犯險-攻頂-危攝追求亡命感覺-231800602.html
Comment 7•7 years ago
|
||
I tested the abvoe two pages on Firefox 51.0.1 on Windows 10. It looks good[1][2]. I cannot reproduce either. [1]: https://gyazo.com/46690dd0529dde295c500fd2cd467870 [2]: https://gyazo.com/a6727bcc0173290d01c7448ded6e5697
Comment 8•7 years ago
|
||
Too late for firefox 52, mass-wontfix.
Updated•7 years ago
|
Priority: -- → P3
Comment 9•2 years ago
|
||
Marking as a duplicate of bug 1474565
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•