1335281 - Rename relatedBrowser to something better

Status: RESOLVED FIXED

(Toolkit :: General, defect)

Description

[Blake Kaplan (:mrbkap) (inactive)]

See bug 1328829, comment 17. We should rename relatedBrowser to something better.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Along with renaming it, could we change to storing the nsIFrameLoader for the content, instead of nsIBrowser (which we currently retrieve the frame loader from in `GetContentParent`)?  For the case of Responsive Design Mode and View Source in bug 1333914, it would be easier to pass around the frame loader for the content because it's loaded in an <iframe mozbrowser>, not a <xul:browser>.

If that seems okay, we could name the property something like "sameProcessAsFrameLoader".

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #1)
> Along with renaming it, could we change to storing the nsIFrameLoader for
> the content, instead of nsIBrowser

I *think* this should work, but I'm not sure. In particular, I don't know if doing this will force us to create a frame loader for browser elements too early (see tabbrowser._createBrowser) or even if that would be a problem.

> If that seems okay, we could name the property something like
> "sameProcessAsFrameLoader".

That sounds fine to me.

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Bug 1335281 - Use frame loader for same process browsers.

This changes the `relatedBrowser` property which held a <xul:browser> to the
more explicit `sameProcessAsFrameLoader` which takes an nsIFrameLoader.

This clarifies the purpose of the property and also (by switching to the frame
loader) makes it easier to set in some contexts.

Review commit: https://reviewboard.mozilla.org/r/112454/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/112454/

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=80869fa203dd44b8446988b980f30453f105537f

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8837293 [details]
Bug 1335281 - Use frame loader for same process browsers.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/112454/diff/1-2/

Comment 6

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2f9b0766cd603dad84c7aa91db5d214d928b15e0

Comment 7

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

In manual testing, view source tabs and windows continue to work as expected with e10s-multi.

Comment 8

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 8837293 [details]
Bug 1335281 - Use frame loader for same process browsers.

https://reviewboard.mozilla.org/r/112454/#review113886

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a273874c2205
Use frame loader for same process browsers. r=mrbkap

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a273874c2205