Rename relatedBrowser to something better

RESOLVED FIXED in Firefox 54

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: mrbkap, Assigned: jryans)

Tracking

Trunk
mozilla54
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox54 fixed)

Details

Attachments

(1 attachment)

See bug 1328829, comment 17. We should rename relatedBrowser to something better.
(Assignee)

Comment 1

2 years ago
Along with renaming it, could we change to storing the nsIFrameLoader for the content, instead of nsIBrowser (which we currently retrieve the frame loader from in `GetContentParent`)?  For the case of Responsive Design Mode and View Source in bug 1333914, it would be easier to pass around the frame loader for the content because it's loaded in an <iframe mozbrowser>, not a <xul:browser>.

If that seems okay, we could name the property something like "sameProcessAsFrameLoader".
Flags: needinfo?(mrbkap)
(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #1)
> Along with renaming it, could we change to storing the nsIFrameLoader for
> the content, instead of nsIBrowser

I *think* this should work, but I'm not sure. In particular, I don't know if doing this will force us to create a frame loader for browser elements too early (see tabbrowser._createBrowser) or even if that would be a problem.

> If that seems okay, we could name the property something like
> "sameProcessAsFrameLoader".

That sounds fine to me.
Flags: needinfo?(mrbkap)
(Assignee)

Updated

2 years ago
Assignee: nobody → jryans
Status: NEW → ASSIGNED
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Comment 7

2 years ago
In manual testing, view source tabs and windows continue to work as expected with e10s-multi.
(Reporter)

Comment 8

2 years ago
mozreview-review
Comment on attachment 8837293 [details]
Bug 1335281 - Use frame loader for same process browsers.

https://reviewboard.mozilla.org/r/112454/#review113886
Attachment #8837293 - Flags: review?(mrbkap) → review+
(Assignee)

Updated

2 years ago
Blocks: 1333914

Comment 9

2 years ago
Pushed by jryans@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/a273874c2205
Use frame loader for same process browsers. r=mrbkap

Comment 10

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a273874c2205
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox54: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54

Updated

2 years ago
Iteration: --- → 54.2 - Feb 20
You need to log in before you can comment on or make changes to this bug.