1335323 - security/sandbox/linux/Sandbox.h:28:42: error: no template named 'vector' in namespace 'std' after landing bug 1330326

Status: RESOLVED FIXED

(Core :: Security: Process Sandboxing, defect)

Description

[Makoto Kato [:m_kato]]

After landing bug 1330326, I hit build error with clang-4.0

 1:12.94 In file included from /mozilla/mozilla-inbound/security/sandbox/linux/Sandbox.cpp:7:
 1:12.94 /mozilla/mozilla-inbound/security/sandbox/linux/Sandbox.h:28:42: error: no template named 'vector' in namespace 'std'; did you mean 'Vector'?
 1:12.94                                          std::vector<int>& aSyscallWhitelist);
 1:12.94                                          ^~~~~~~~~~~
 1:12.94                                          Vector
 1:12.94 /mozilla/objdir-ib/dist/include/mozilla/Vector.h:281:7: note: 'Vector' declared here
 1:12.94 class Vector final : private AllocPolicy

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Sandbox.h doesn't seem to #include or declare vector

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Attachment: move #include to header

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/adab5d5d0372
Move vector include to sandbox header to fix bustage. r=bustage-fix a=bustage-fix

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

forward declaration should work too, I guess.

Comment 5

[Bill Gianopoulos [:WG9s]]

So how come this did not fail on try or in inbound or wherever it was merged from.

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Because of unified builds?